[GitHub] emilianbold closed pull request #411: Fixes bug that prevents NetBeans from quitting on macOS

[GitBox <gi...@apache.org>]

emilianbold closed pull request #411: Fixes bug that prevents NetBeans from quitting on macOS
URL: https://github.com/apache/incubator-netbeans/pull/411
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK8.java b/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK8.java
index 39d499bff..8810bcc7a 100644
--- a/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK8.java
+++ b/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK8.java
@@ -79,5 +79,7 @@ public void handlePreferences(AppEvent.PreferencesEvent e) {
     @Override
     public void handleQuitRequestWith(AppEvent.QuitEvent e, QuitResponse response) {
         handleQuit();
+        //need to do this otherwise the user will never be able to quit again
+        response.cancelQuit();
     }
 }
diff --git a/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK9.java b/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK9.java
index 6eed4f758..65523bb0c 100644
--- a/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK9.java
+++ b/applemenu/src/org/netbeans/modules/applemenu/NbApplicationAdapterJDK9.java
@@ -82,5 +82,7 @@ public void handlePreferences(PreferencesEvent e) {
     @Override
     public void handleQuitRequestWith(QuitEvent e, QuitResponse response) {
         handleQuit();
+        //need to do this otherwise the user will never be able to quit again
+        response.cancelQuit();
     }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists