[GitHub] [incubator-superset] john-bodley commented on issue #9582: [fix] Fixing issue with Jinja filter_value

[GitBox <gi...@apache.org>]

john-bodley commented on issue #9582:
URL: https://github.com/apache/incubator-superset/pull/9582#issuecomment-616232218


   @villebro how do you want to proceed? I think are approaches are similar except you have the added step of `split_adhoc_filters_into_base_filters(...)`. 
   
   I realize that the filter logic is is somewhat unpleasant as we still have ad-hoc (current) and base (previous) versions of the filters. I did think about re-converting the ad-hoc filters into base filters but felt that this was a step in the wrong direction. 
   
   Orthogonal to this PR I think these ad-hoc filters should be a class as it feels fragile dealing with a non-typed dictionary for defining filters.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org