You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/07/26 05:05:45 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #42165: [SPARK-44552][SQL] Remove `private object ParseState` definition from `IntervalUtils`
LuciferYang opened a new pull request, #42165:
URL: https://github.com/apache/spark/pull/42165
### What changes were proposed in this pull request?
SPARK-44326(https://github.com/apache/spark/pull/41885/files#diff-e695bcf363031df04cc16c96f1b62fb35093807ee1157c3cbecae3cccb9a3f4e) moved the relevant code from `IntervalUtils` to `SparkIntervalUtils` (including `private object ParseState` definition), but did not delete the definition of `private object ParseState` in `IntervalUtils`. So this pr cleans up it.
### Why are the changes needed?
Code cleanup.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass Github Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #42165: [SPARK-44552][SQL] Remove `private object ParseState` definition from `IntervalUtils`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #42165: [SPARK-44552][SQL] Remove `private object ParseState` definition from `IntervalUtils`
URL: https://github.com/apache/spark/pull/42165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42165: [SPARK-44552][SQL] Remove `private object ParseState` definition from `IntervalUtils`
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42165:
URL: https://github.com/apache/spark/pull/42165#issuecomment-1655434366
Merged into Master and branch-3.5 (branch-3.5 also include the refactor work https://github.com/apache/spark/pull/41885)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org