You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/07/01 21:17:42 UTC
[GitHub] [nifi-minifi-cpp] arpadboda opened a new pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
arpadboda opened a new pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#issuecomment-688756547
Closing, this was just a POC, will be properly done in #839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#discussion_r450121956
##########
File path: extensions/rocksdb-repos/FlowFileRepository.cpp
##########
@@ -152,7 +153,10 @@ void FlowFileRepository::prune_stored_flowfiles() {
// we find the connection for the persistent flowfile, create the flowfile and enqueue that
std::shared_ptr<core::FlowFile> flow_file_ref = std::static_pointer_cast<core::FlowFile>(eventRead);
eventRead->setStoredToRepository(true);
- search->second->put(eventRead);
+ auto connection = std::static_pointer_cast<Connection>(search->second);
Review comment:
if the #807 is merged Processors might also be FlowFile containers (like `BinFiles`) and those files should also be restored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#issuecomment-652651449
This is tagged for 1.0.0 and WIP, please do NOT merge under any circumstance!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
hunyadi-dev commented on pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#issuecomment-665079380
Minor, but this PR is only named WIP, but is not a draft. Also targets `master`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda commented on pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
arpadboda commented on pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#issuecomment-665116201
> Minor, but this PR is only named WIP, but is not a draft. Also targets `master`.
Which makes me happy as it surely cannot be merged. :) It is just a POC, will be closed soon, should be properly done in #839
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #829: WIP: MINIFICPP-1279 - FlowFile shouldn't inherit from Connectable
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #829:
URL: https://github.com/apache/nifi-minifi-cpp/pull/829#discussion_r450121956
##########
File path: extensions/rocksdb-repos/FlowFileRepository.cpp
##########
@@ -152,7 +153,10 @@ void FlowFileRepository::prune_stored_flowfiles() {
// we find the connection for the persistent flowfile, create the flowfile and enqueue that
std::shared_ptr<core::FlowFile> flow_file_ref = std::static_pointer_cast<core::FlowFile>(eventRead);
eventRead->setStoredToRepository(true);
- search->second->put(eventRead);
+ auto connection = std::static_pointer_cast<Connection>(search->second);
Review comment:
if #807 is merged Processors can also be FlowFile containers (like `BinFiles`) and those files should also be restored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org