[GitHub] [iceberg] szehon-ho edited a comment on pull request #3457: Core: Improve performance of expire snapshot by not double-scanning retained Snapshots

[GitBox <gi...@apache.org>]

szehon-ho edited a comment on pull request #3457:
URL: https://github.com/apache/iceberg/pull/3457#issuecomment-964782339


   I think this is actually promising, the performance gain is in line with expectation.
   
   Test: table with 1000 small snapshots, expire 1 at a time.  The time and resources spent in expire-snapshot and input/shuffle sizes falls by little less than half, as most snapshots are not double-scanned.
   
   Current:
   <img width="1508" alt="Screenshot 2021-11-09 at 20 38 28" src="https://user-images.githubusercontent.com/20555759/141051133-0e66e65d-054d-49c7-9981-31c789b24596.png">
   
   Optimized:
   <img width="1508" alt="Screenshot 2021-11-09 at 20 38 22" src="https://user-images.githubusercontent.com/20555759/141051111-16bef85c-9e89-4e2c-9917-358029e75919.png">
   
   So I think it's worth to continue.  @rdblue  thanks for the early review, I will look at the comments and make the changes
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org