You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2008/09/09 07:41:44 UTC

[jira] Created: (HADOOP-4122) Duplicate code in JobHistory TaskAttempt's can be collapsed into super class.

Duplicate code in JobHistory TaskAttempt's can be collapsed into super class. 
------------------------------------------------------------------------------

                 Key: HADOOP-4122
                 URL: https://issues.apache.org/jira/browse/HADOOP-4122
             Project: Hadoop Core
          Issue Type: Improvement
          Components: mapred
            Reporter: Amareshwari Sriramadasu
            Priority: Minor


There is a lot of common code for MapAttempt, ReduceAttempt, CleanupAttempt (added in HADOOP-4112). All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HADOOP-4122) Duplicate code in JobHistory TaskAttempt's can be collapsed into super class.

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4122:
--------------------------------------------

      Description: There is a lot of common code for MapAttempt, ReduceAttempt. All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.  (was: There is a lot of common code for MapAttempt, ReduceAttempt, CleanupAttempt (added in HADOOP-4112). All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.)
         Priority: Blocker  (was: Minor)
    Fix Version/s: 0.19.0
         Assignee: Amareshwari Sriramadasu

> Duplicate code in JobHistory TaskAttempt's can be collapsed into super class. 
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-4122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4122
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> There is a lot of common code for MapAttempt, ReduceAttempt. All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HADOOP-4122) Duplicate code in JobHistory TaskAttempt's can be collapsed into super class.

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636575#action_12636575 ] 

Amareshwari Sriramadasu commented on HADOOP-4122:
-------------------------------------------------

The methods logFailed() and logKilled() in JobInfo can also be merged into one method, since they differ only in one value. 

All the classes and all the methods to log the Job and task information, in JobHistory, are exposed to public, which is not necessary. They should be package private. This jira can make them package private. 

Thoughts?


> Duplicate code in JobHistory TaskAttempt's can be collapsed into super class. 
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-4122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4122
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> There is a lot of common code for MapAttempt, ReduceAttempt. All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HADOOP-4122) Duplicate code in JobHistory TaskAttempt's can be collapsed into super class.

Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Amareshwari Sriramadasu updated HADOOP-4122:
--------------------------------------------

         Priority: Major  (was: Blocker)
    Fix Version/s:     (was: 0.19.0)

Discussed with Devaraj. This doesn't need to be blocker for 0.19

> Duplicate code in JobHistory TaskAttempt's can be collapsed into super class. 
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-4122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4122
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>
> There is a lot of common code for MapAttempt, ReduceAttempt. All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.