You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/10/09 17:56:42 UTC
svn commit: r1843317 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Author: tilman
Date: Tue Oct 9 17:56:42 2018
New Revision: 1843317
URL: http://svn.apache.org/viewvc?rev=1843317&view=rev
Log:
PDFBOX-4333: Reduce the total number of break and continue statements in this loop for SonarQube
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java?rev=1843317&r1=1843316&r2=1843317&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/pdfparser/COSParser.java Tue Oct 9 17:56:42 2018
@@ -2303,17 +2303,12 @@ public class COSParser extends BaseParse
List<? extends COSBase> kidsList = kidsArray.toList();
for (COSBase kid : kidsList)
{
- if (!(kid instanceof COSObject))
+ if (!(kid instanceof COSObject) || set.contains((COSObject) kid))
{
kidsArray.remove(kid);
continue;
}
COSObject kidObject = (COSObject) kid;
- if (set.contains(kidObject))
- {
- kidsArray.remove(kid);
- continue;
- }
COSBase kidBaseobject = kidObject.getObject();
// object wasn't dereferenced -> remove it
if (kidBaseobject.equals(COSNull.NULL))