You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/10/16 09:51:12 UTC
Review Request 39387: Make health check run outside for docker
container task.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Bugs: MESOS-3599
https://issues.apache.org/jira/browse/MESOS-3599
Repository: mesos
Description
-------
Make health check run outside for docker container task.
Diffs
-----
src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
Diff: https://reviews.apache.org/r/39387/diff/
Testing
-------
make -j8 check
Thanks,
haosdent huang
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by haosdent huang <ha...@gmail.com>.
> On Nov. 23, 2015, 7:44 p.m., Timothy Chen wrote:
> > src/docker/executor.cpp, line 324
> > <https://reviews.apache.org/r/39387/diff/2/?file=1137477#file1137477line324>
> >
> > I don't see you handling the else case here?
For else case, it would keep use the original health check here.
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review107635
-----------------------------------------------------------
On Nov. 29, 2015, 5:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 5:10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make health check run outside for docker container task.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
> include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
> src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
> src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
>
> Diff: https://reviews.apache.org/r/39387/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review107635
-----------------------------------------------------------
src/docker/executor.cpp (line 324)
<https://reviews.apache.org/r/39387/#comment166864>
I don't see you handling the else case here?
- Timothy Chen
On Nov. 23, 2015, 5:07 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 5:07 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make health check run outside for docker container task.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26
> include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4
> src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
>
> Diff: https://reviews.apache.org/r/39387/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review108276
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39387]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 29, 2015, 5:10 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2015, 5:10 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make health check run outside for docker container task.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
> include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
> src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
> src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
>
> Diff: https://reviews.apache.org/r/39387/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/
-----------------------------------------------------------
(Updated Nov. 29, 2015, 5:10 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Add test case for run health check outside docker container.
Bugs: MESOS-3599
https://issues.apache.org/jira/browse/MESOS-3599
Repository: mesos
Description
-------
Make health check run outside for docker container task.
Diffs (updated)
-----
include/mesos/mesos.proto 27971fea6935b82d7034397edaa7a37edb1f6f38
include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd
src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02
Diff: https://reviews.apache.org/r/39387/diff/
Testing
-------
make -j8 check
Thanks,
haosdent huang
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review107630
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39387]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 23, 2015, 5:07 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 5:07 p.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make health check run outside for docker container task.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26
> include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4
> src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
>
> Diff: https://reviews.apache.org/r/39387/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 5:07 p.m.)
Review request for mesos and Timothy Chen.
Changes
-------
Switch to use option to specify running command outside container.
Bugs: MESOS-3599
https://issues.apache.org/jira/browse/MESOS-3599
Repository: mesos
Description
-------
Make health check run outside for docker container task.
Diffs (updated)
-----
include/mesos/mesos.proto 0b8289fd405bdd3a25ea49151abc4a2ccf486f26
include/mesos/v1/mesos.proto c98f2a49c3ec9b867053969839645126966587d4
src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2
Diff: https://reviews.apache.org/r/39387/diff/
Testing
-------
make -j8 check
Thanks,
haosdent huang
Re: Review Request 39387: Make health check run outside for docker
container task.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39387/#review102911
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39387]
All tests passed.
- Mesos ReviewBot
On Oct. 16, 2015, 7:51 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39387/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2015, 7:51 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Bugs: MESOS-3599
> https://issues.apache.org/jira/browse/MESOS-3599
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Make health check run outside for docker container task.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp c04757c32d5e354f7da60fa28b940eb68e1d9c9f
> src/docker/executor.cpp 1e4901335854c49e46cd7b132e79ccb11cd72ade
> src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade
>
> Diff: https://reviews.apache.org/r/39387/diff/
>
>
> Testing
> -------
>
> make -j8 check
>
>
> Thanks,
>
> haosdent huang
>
>