[GitHub] [superset] AAfghahi commented on a diff in pull request #23004: fix: Datasource Url error

["AAfghahi (via GitHub)" <gi...@apache.org>]

AAfghahi commented on code in PR #23004:
URL: https://github.com/apache/superset/pull/23004#discussion_r1100707808


##########
superset/models/helpers.py:
##########
@@ -750,13 +750,30 @@ def columns(self) -> List[Any]:
     def get_fetch_values_predicate(self) -> List[Any]:
         raise NotImplementedError()
 
+    @property
+    def default_endpoint(self) -> sa.Text:
+        raise NotImplementedError()
+
+    @property

Review Comment:
   Oh I incluyded this because of the mypy error 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org