You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/09/28 01:05:15 UTC
[GitHub] jihoonson commented on a change in pull request #6383: [WIP]
Prevent failed KafkaConsumer creation from blocking overlord startup
jihoonson commented on a change in pull request #6383: [WIP] Prevent failed KafkaConsumer creation from blocking overlord startup
URL: https://github.com/apache/incubator-druid/pull/6383#discussion_r221118557
##########
File path: extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/indexing/kafka/supervisor/KafkaSupervisor.java
##########
@@ -260,6 +261,7 @@ public String toString()
private volatile DateTime firstRunTime;
private volatile KafkaConsumer consumer;
+ private volatile boolean lifecycleStarted = false;
Review comment:
How about adding a new `InitNotice`? It can be processed by the existing `exec`, so we don't have to add a new `initializationExec`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org