You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Vadim Kirilchuk (JIRA)" <ji...@apache.org> on 2013/07/23 12:18:48 UTC
[jira] [Updated] (SOLR-5067) TestReplicationHandler
doTestReplicateAfterWrite2Slave bad test
[ https://issues.apache.org/jira/browse/SOLR-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vadim Kirilchuk updated SOLR-5067:
----------------------------------
Description:
Hi,
TestReplicationHandler#doTestReplicateAfterWrite2Slave has some commented code which actually performs necessary assertions.
https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
While these assertions commented out it checks nothing. Also as index fetching starts in a new thread it's worth to perform fetchindex with 'wait' parameter. (Previously Thread.sleep( n ) was used here)
was:
Hi,
TestReplicationHandler#doTestReplicateAfterWrite2Slave has some commented code which actually performs necessary assertions.
https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
While these assertions commented out it checks nothing. Also as index fetching starts in a new thread it's worth to perform fetchindex with 'wait' parameter. (Previously Thread.sleep(n) was used here)
> TestReplicationHandler doTestReplicateAfterWrite2Slave bad test
> ---------------------------------------------------------------
>
> Key: SOLR-5067
> URL: https://issues.apache.org/jira/browse/SOLR-5067
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Reporter: Vadim Kirilchuk
>
> Hi,
> TestReplicationHandler#doTestReplicateAfterWrite2Slave has some commented code which actually performs necessary assertions.
> https://github.com/apache/lucene-solr/blob/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
> While these assertions commented out it checks nothing. Also as index fetching starts in a new thread it's worth to perform fetchindex with 'wait' parameter. (Previously Thread.sleep( n ) was used here)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org