You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@drill.apache.org by js...@apache.org on 2015/09/25 02:20:42 UTC

[1/2] drill git commit: DRILL-3778: Add missed part of DRILL-3160 (making JDBC Javadoc available).

Repository: drill
Updated Branches:
  refs/heads/master d2caa62e1 -> b8573526d


DRILL-3778: Add missed part of DRILL-3160 (making JDBC Javadoc available).

This closes #158

Main:
Configured Javadoc generation (title, package groups, version in headers).
Added link to JDBC page in Drill documentation site.
Edited/fixed some JDBC Javadoc comments.
Added explicit SQLConversionOverflowException to throws clauses for Javadoc
effect.
Added some imports for Javadoc references.

Misc.:
Fixed a couple Javadoc syntax errors.
Fixed POM indentation.


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/b6282987
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/b6282987
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/b6282987

Branch: refs/heads/master
Commit: b628298767ae7a82a0415f64df88b01b43fec3e5
Parents: d2caa62
Author: dbarclay <db...@maprtech.com>
Authored: Mon Sep 14 10:54:34 2015 -0700
Committer: Jason Altekruse <al...@gmail.com>
Committed: Thu Sep 24 16:09:54 2015 -0700

----------------------------------------------------------------------
 .../apache/drill/common/util/PathScanner.java   |   2 +-
 .../drill/exec/work/batch/RawBatchBuffer.java   |   2 +-
 exec/jdbc-all/pom.xml                           | 101 ++++++++++++-------
 .../drill/jdbc/AlreadyClosedSqlException.java   |   2 +-
 .../org/apache/drill/jdbc/DrillConnection.java  |   2 +-
 .../drill/jdbc/DrillConnectionConfig.java       |   1 -
 .../org/apache/drill/jdbc/DrillResultSet.java   |  48 +++++----
 .../jdbc/InvalidCursorStateSqlException.java    |   2 +-
 .../apache/drill/jdbc/JdbcApiSqlException.java  |   5 +-
 .../org/apache/drill/jdbc/package-info.java     |  10 +-
 .../drill/jdbc/proxy/TracingProxyDriver.java    |   4 +-
 .../apache/drill/jdbc/proxy/package-info.java   |   1 +
 12 files changed, 114 insertions(+), 66 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/common/src/main/java/org/apache/drill/common/util/PathScanner.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/drill/common/util/PathScanner.java b/common/src/main/java/org/apache/drill/common/util/PathScanner.java
index a44bdf2..9ee487b 100644
--- a/common/src/main/java/org/apache/drill/common/util/PathScanner.java
+++ b/common/src/main/java/org/apache/drill/common/util/PathScanner.java
@@ -133,7 +133,7 @@ public class PathScanner {
    * @param  classLoaders  set of class loaders in which to look up resource;
    *           none (empty array) to specify to use current thread's context
    *           class loader and {@link Reflections}'s class loader
-   * @returns  ...; empty set if none
+   * @return  ...; empty set if none
    */
   public static Set<URL> forResource(final String resourcePathname,
                                      final boolean returnRootPathname,

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java b/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java
index 0441eca..0540820 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/RawBatchBuffer.java
@@ -35,7 +35,7 @@ public interface RawBatchBuffer extends RawFragmentBatchProvider {
    * @param batch
    *          Batch to enqueue
    * @throws IOException
-   * @returns Whether response should be returned.
+   * @return Whether response should be returned.
    */
   public void enqueue(RawFragmentBatch batch) throws IOException;
 }

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc-all/pom.xml
----------------------------------------------------------------------
diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
index d2cff3f..4a7c57d 100644
--- a/exec/jdbc-all/pom.xml
+++ b/exec/jdbc-all/pom.xml
@@ -392,37 +392,37 @@
            <filter>
              <artifact>*:*</artifact>
              <excludes>
-                <exclude>**/logback.xml</exclude>
-                <exclude>**/LICENSE.txt</exclude>
-                <exclude>**/*.java</exclude>
-                <exclude>**/META-INF/**</exclude>
-                <exclude>**/org.codehaus.commons.compiler.properties</exclude>
-                <exclude>**/*.SF</exclude>
-                <exclude>**/*.RSA</exclude>
-                <exclude>**/*.DSA</exclude>
-                <exclude>javax/**</exclude>
-                <exclude>rest/**</exclude>
-                <exclude>*.tokens</exclude>
-                <exclude>com/google/common/math</exclude>
-                <exclude>com/google/common/net</exclude>
-                <exclude>com/google/common/primitives</exclude>
-                <exclude>com/google/common/reflect</exclude>
-                <exclude>com/google/common/util</exclude>
-                <exclude>com/google/common/cache</exclude>
-                <exclude>com/google/common/collect/Tree*</exclude>
-                <exclude>com/google/common/collect/Standard*</exclude>
-                <exclude>org/apache/drill/exec/expr/annotations/**</exclude>
-                <exclude>org/apache/drill/exec/expr/fn/**</exclude>
-                <exclude>org/apache/drill/exec/proto/beans/**</exclude>
-                <exclude>org/apache/drill/exec/compile/**</exclude>
-                <exclude>org/apache/drill/exec/planner/**</exclude>
-                <exclude>org/apache/drill/exec/physical/**</exclude>
-                <exclude>org/apache/drill/exec/store/**</exclude>
-                <exclude>org/apache/drill/exec/server/rest/**</exclude>
-                <exclude>org/apache/drill/exec/rpc/data/**</exclude>
-                <exclude>org/apache/drill/exec/rpc/control/**</exclude>
-                <exclude>org/apache/drill/exec/work/**</exclude>
-              </excludes>
+               <exclude>**/logback.xml</exclude>
+               <exclude>**/LICENSE.txt</exclude>
+               <exclude>**/*.java</exclude>
+               <exclude>**/META-INF/**</exclude>
+               <exclude>**/org.codehaus.commons.compiler.properties</exclude>
+               <exclude>**/*.SF</exclude>
+               <exclude>**/*.RSA</exclude>
+               <exclude>**/*.DSA</exclude>
+               <exclude>javax/**</exclude>
+               <exclude>rest/**</exclude>
+               <exclude>*.tokens</exclude>
+               <exclude>com/google/common/math</exclude>
+               <exclude>com/google/common/net</exclude>
+               <exclude>com/google/common/primitives</exclude>
+               <exclude>com/google/common/reflect</exclude>
+               <exclude>com/google/common/util</exclude>
+               <exclude>com/google/common/cache</exclude>
+               <exclude>com/google/common/collect/Tree*</exclude>
+               <exclude>com/google/common/collect/Standard*</exclude>
+               <exclude>org/apache/drill/exec/expr/annotations/**</exclude>
+               <exclude>org/apache/drill/exec/expr/fn/**</exclude>
+               <exclude>org/apache/drill/exec/proto/beans/**</exclude>
+               <exclude>org/apache/drill/exec/compile/**</exclude>
+               <exclude>org/apache/drill/exec/planner/**</exclude>
+               <exclude>org/apache/drill/exec/physical/**</exclude>
+               <exclude>org/apache/drill/exec/store/**</exclude>
+               <exclude>org/apache/drill/exec/server/rest/**</exclude>
+               <exclude>org/apache/drill/exec/rpc/data/**</exclude>
+               <exclude>org/apache/drill/exec/rpc/control/**</exclude>
+               <exclude>org/apache/drill/exec/work/**</exclude>
+             </excludes>
            </filter>
          </filters>
         </configuration>
@@ -462,14 +462,43 @@
                 </goals>
                 <inherited>false</inherited>
                 <configuration>
-                  <!-- Only inlcude the published interface in the java-doc. Unfortunately,
-                       the javadoc tool and in turn, the plugin does not support inclusion
-                       pattern and hence we have to rely on exclusion pattern. -->
-                  <excludePackageNames>org.apache.drill.jdbc.impl</excludePackageNames>
                   <includeDependencySources>true</includeDependencySources>
                   <dependencySourceIncludes>
                     <dependencySourceInclude>org.apache.drill.exec:drill-jdbc</dependencySourceInclude>
                   </dependencySourceIncludes>
+                  <!-- Include only the published interface in the Javadoc-
+                       generated documentation.  Unfortunately, the plugin does
+                       not support inclusion patterns and hence we have to rely
+                       on an exclusion pattern. -->
+                  <excludePackageNames>org.apache.drill.jdbc.impl</excludePackageNames>
+
+                  <!-- windowtitle: common part of window titles (goes in
+                       parentheses at end of window title, after in-page title
+                       (e.g., package name)) -->
+                  <windowtitle>
+                    Apache Drill JDBC Driver v. ${project.version}
+                  </windowtitle>
+
+                  <!-- header, footer:  small text at right edge of
+                       top, bottom Overview/Package/etc. menu bars -->
+                  <header>Apache Drill JDBC Driver v. ${project.version}</header>
+                  <footer>Apache Drill JDBC Driver v. ${project.version}</footer>
+
+                  <!-- doctitle:  in-page title for overview page  -->
+                  <doctitle>
+                    Apache Drill JDBC Driver version ${project.version}
+                  </doctitle>
+                  <groups>
+                    <group>
+                      <title>Drill JDBC Driver</title>
+                      <packages>org.apache.drill.jdbc</packages>
+                    </group>
+                    <group>
+                      <title>Tracing Proxy JDBC Driver</title>
+                      <packages>org.apache.drill.jdbc.proxy</packages>
+                    </group>
+                  </groups>
+
                 </configuration>
               </execution>
             </executions>
@@ -478,7 +507,7 @@
       </build>
     </profile>
     <!-- mondrian data includes 10s of MBs of JSON file if you want to include 
-      them run maven with -Pwith-mondrian-data -->
+         them run maven with -Pwith-mondrian-data -->
     <profile>
       <id>with-mondrian-data</id>
       <activation>

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java
index 5c34868..44dc9d6 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/AlreadyClosedSqlException.java
@@ -17,7 +17,7 @@
  */
 package org.apache.drill.jdbc;
 
-import java.sql.Statement;
+import java.sql.Statement;  // (for Javadoc reference(s))
 
 
 /**

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java
index 511447c..698b433 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnection.java
@@ -80,7 +80,7 @@ public interface DrillConnection extends Connection {
   /**
    * <strong>Drill</strong>:
    * Not supported.  Always throws {@link SQLFeatureNotSupportedException} (or
-   * {@link AlreadyClosedSqlException})..
+   * {@link AlreadyClosedSqlException}).
    */
   @Override
   void commit() throws SQLException;

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java
index 917d639..702c9b9 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillConnectionConfig.java
@@ -29,7 +29,6 @@ import net.hydromatic.avatica.ConnectionConfigImpl;
 // org.apache.drill.jdbc to class in implementation package
 // org.apache.drill.jdbc.impl.
 /**
- *  ...
  *  <p>
  *    NOTE:  DrillConnectionConfig will be changed from a class to an interface.
  *  </p>

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
index 31fbf10..88fd700 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillResultSet.java
@@ -103,10 +103,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code byte} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert
+   *   to convert to {@code byte}
    */
   @Override
-  byte getByte(int columnIndex) throws SQLException;
+  byte getByte(int columnIndex) throws SQLConversionOverflowException,
+                                       SQLException;
 
   /**
    * {@inheritDoc}
@@ -130,10 +131,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code short} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert
+   *   to convert to {@code short}
    */
   @Override
-  short getShort(int columnIndex) throws SQLException;
+  short getShort(int columnIndex) throws SQLConversionOverflowException,
+                                         SQLException;
 
   /**
    * {@inheritDoc}
@@ -157,10 +159,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code int} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert to int
+   *   to convert to {@code int}
    */
   @Override
-  int getInt(int columnIndex) throws SQLException;
+  int getInt(int columnIndex) throws SQLConversionOverflowException,
+                                     SQLException;
 
   /**
    * {@inheritDoc}
@@ -184,10 +187,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code long} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert
+   *   to convert to {@code long}
    */
   @Override
-  long getLong(int columnIndex) throws SQLException;
+  long getLong(int columnIndex) throws SQLConversionOverflowException,
+                                       SQLException;
 
   /**
    * {@inheritDoc}
@@ -211,10 +215,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code float} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert
+   *   to convert to {@code float}
    */
   @Override
-  float getFloat(int columnIndex) throws SQLException;
+  float getFloat(int columnIndex) throws SQLConversionOverflowException,
+                                         SQLException;
 
   /**
    * {@inheritDoc}
@@ -238,10 +243,11 @@ public interface DrillResultSet extends ResultSet  {
    *   value whose magnitude is outside the range of {@code double} values.
    * </p>
    * @throws  SQLConversionOverflowException  if a source value was too large
-   *   to convert
+   *   to convert to {@code double}
    */
   @Override
-  double getDouble(int columnIndex) throws SQLException;
+  double getDouble(int columnIndex) throws SQLConversionOverflowException,
+                                           SQLException;
 
   /**
    * {@inheritDoc}
@@ -295,7 +301,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  byte getByte(String columnLabel) throws SQLException;
+  byte getByte(String columnLabel) throws SQLConversionOverflowException,
+                                          SQLException;
 
   /**
    * {@inheritDoc}
@@ -305,7 +312,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  short getShort(String columnLabel) throws SQLException;
+  short getShort(String columnLabel) throws SQLConversionOverflowException,
+                                            SQLException;
 
   /**
    * {@inheritDoc}
@@ -315,7 +323,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  int getInt(String columnLabel) throws SQLException;
+  int getInt(String columnLabel) throws SQLConversionOverflowException,
+                                        SQLException;
 
   /**
    * {@inheritDoc}
@@ -325,7 +334,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  long getLong(String columnLabel) throws SQLException;
+  long getLong(String columnLabel) throws SQLConversionOverflowException,
+                                          SQLException;
 
   /**
    * {@inheritDoc}
@@ -335,7 +345,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  float getFloat(String columnLabel) throws SQLException;
+  float getFloat(String columnLabel) throws SQLConversionOverflowException,
+                                            SQLException;
 
   /**
    * {@inheritDoc}
@@ -345,7 +356,8 @@ public interface DrillResultSet extends ResultSet  {
    * </p>
    */
   @Override
-  double getDouble(String columnLabel) throws SQLException;
+  double getDouble(String columnLabel) throws SQLConversionOverflowException,
+                                              SQLException;
 
   /**
    * {@inheritDoc}

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java
index d6929d2..ad99251 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/InvalidCursorStateSqlException.java
@@ -17,7 +17,7 @@
  */
 package org.apache.drill.jdbc;
 
-import java.sql.ResultSet;
+import java.sql.ResultSet;  // (for Javadoc reference(s))
 
 
 /**

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java
index f844fdc..7d6ece0 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/JdbcApiSqlException.java
@@ -21,8 +21,9 @@ import java.sql.ResultSet;
 import java.sql.SQLDataException;
 import java.sql.SQLException;
 import java.sql.SQLNonTransientException;
-import java.sql.SQLSyntaxErrorException;
-import java.sql.SQLTransientException;
+import java.sql.SQLSyntaxErrorException;  // (for Javadoc reference(s))
+import java.sql.SQLTransientException;  // (for Javadoc reference(s))
+import java.sql.ResultSet;  // (for Javadoc reference(s))
 
 
 /**

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java
index 2a4eb62..86ce9e7 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/package-info.java
@@ -1,4 +1,4 @@
-/**
+/*
  * Licensed to the Apache Software Foundation (ASF) under one
  * or more contributor license agreements.  See the NOTICE file
  * distributed with this work for additional information
@@ -19,7 +19,13 @@
 /**
  * JDBC driver for Drill.
  * <p>
- *   Drill's JDBC driver class is {@link org.apache.drill.jdbc.Driver}.
+ *   Drill's JDBC driver class is
+ *   {@link org.apache.drill.jdbc.Driver org.apache.drill.jdbc.Driver}.
  * </p>
+ *
+ * @see
+ * <a href="http://drill.apache.org/docs/using-the-jdbc-driver">Using the JDBC Driver</a>
+ * in the on-line
+ * <a href="http://drill.apache.org/docs">Apache Drill Documentation</a>
  */
 package org.apache.drill.jdbc;

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java
index af81a19..760dcf8 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/TracingProxyDriver.java
@@ -76,8 +76,8 @@ import static org.slf4j.LoggerFactory.getLogger;
  * </ul>
  * <p><strong>Output:</strong></p>
  * <p>
- *   Currently, the tracing output line are simply written to {@link System#out}
- *   ({@code stdout} or "standard output").
+ *   Currently, the tracing output lines are simply written to
+ *   {@link System#out} ({@code stdout} or "standard output").
  * </p>
  */
 public class TracingProxyDriver implements java.sql.Driver {

http://git-wip-us.apache.org/repos/asf/drill/blob/b6282987/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java
----------------------------------------------------------------------
diff --git a/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java b/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java
index 33b915b..94f52c4 100644
--- a/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java
+++ b/exec/jdbc/src/main/java/org/apache/drill/jdbc/proxy/package-info.java
@@ -15,6 +15,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
 /**
  * Tracing proxy JDBC driver.  Traces calls to another JDBC driver.
  *


[2/2] drill git commit: DRILL-3836: Find free port automatically in TestBitRpc

Posted by js...@apache.org.
DRILL-3836: Find free port automatically in TestBitRpc

This closes #168


Project: http://git-wip-us.apache.org/repos/asf/drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/drill/commit/b8573526
Tree: http://git-wip-us.apache.org/repos/asf/drill/tree/b8573526
Diff: http://git-wip-us.apache.org/repos/asf/drill/diff/b8573526

Branch: refs/heads/master
Commit: b8573526da7403270002fe1524b683d04c4c7909
Parents: b628298
Author: Julien Le Dem <ju...@ledem.net>
Authored: Thu Sep 24 13:52:08 2015 -0700
Committer: Jason Altekruse <al...@gmail.com>
Committed: Thu Sep 24 16:10:46 2015 -0700

----------------------------------------------------------------------
 .../src/test/java/org/apache/drill/exec/server/TestBitRpc.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/drill/blob/b8573526/exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java b/exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java
index 72e6c44..71b0b1d 100644
--- a/exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java
+++ b/exec/java-exec/src/test/java/org/apache/drill/exec/server/TestBitRpc.java
@@ -88,7 +88,7 @@ public class TestBitRpc extends ExecTest {
     DataResponseHandler drp = new BitComTestHandler();
     DataServer server = new DataServer(c, workBus, drp);
 
-    port = server.bind(port, false);
+    port = server.bind(port, true);
     DrillbitEndpoint ep = DrillbitEndpoint.newBuilder().setAddress("localhost").setDataPort(port).build();
     DataConnectionManager manager = new DataConnectionManager(ep, c2);
     DataTunnel tunnel = new DataTunnel(manager);