You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:49:19 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1517: sched/wdog: Change the default value of MAX_WDOGPARMS from 4 to 2

xiaoxiang781216 commented on pull request #1517:
URL: https://github.com/apache/incubator-nuttx/pull/1517#issuecomment-669975445


   > I understand why you remove all occurrences of `CONFIG_MAX_WDOGPARMS=2` when the default changed to 2, but whcy do you remove `CONFIG_MAX_WDOGPARMS=1`? Those are tiny configurations that might depend on the smaller value. I think you should restore those few cases.
   > 
   
   Because pthread_condclockwait require two arguments:
   ```
   https://github.com/apache/incubator-nuttx/blob/master/sched/pthread/pthread_condclockwait.c#L289
   ```
   It's dangerous to set CONFIG_MAX_WDOGPARMS=1 but don't set CONFIG_DISABLE_PTHREAD=y
   Anyway, I will provide a patch to remove wd_pool which will release 1KB by default, so the expansion here is safe.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org