You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2021/09/19 17:25:54 UTC

[GitHub] [avro] wx930910 commented on pull request #1341: refactor printinVisitor to improve testing logic

wx930910 commented on pull request #1341:
URL: https://github.com/apache/avro/pull/1341#issuecomment-922508284


   In addition to this change, I think if we only use PrintingVisitor to log out information, we can actually get rid of `PrintingVisitor` and spy `CloningVisitor`, then use `Mockito.verify()` to verify method execution times and `Mockito.inOrder()` to verify the method execution order based on the given Schema. We can make test condition more clear and empower test case by verify execution order explictly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org