You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by Kiko <ki...@gmail.com> on 2008/12/23 21:08:49 UTC

DESTDIR in Makefile.am

Can someone fix the Makefile.am in the main dir
it doesn't have support for DESTDIR
so using make install DESTDIR=/wherever wouldn't work with the modules

--- Makefile.am 2008-12-23 02:09:34 -0500
+++ Makefile.am.new     2008-12-23 15:12:53 -0500
@@ -16,11 +16,11 @@
        $(SHELL) ./config.status --recheck

 install-data-local:
-       $(mkinstalldirs) $(RIVETLIB_DESTDIR)
-       cp -r rivet/* $(RIVETLIB_DESTDIR)
-       -( cd  $(RIVETLIB_DESTDIR) ; echo 'eval pkg_mkIndex -verbose [pwd] 
init.tcl [glob [file join packages * *.tcl] [file join *[info 
sharedlibextension]]]' | @TCLSH_PROG@ ; )
+       $(mkinstalldirs) ${DESTDIR}$(RIVETLIB_DESTDIR)
+       cp -r rivet/* ${DESTDIR}$(RIVETLIB_DESTDIR)
+       -( cd  ${DESTDIR}$(RIVETLIB_DESTDIR) ; echo 'eval 
pkg_mkIndex -verbose [pwd] init.tcl [glob [file join packages * *.tcl] [file 
join *[info sharedlibextension]]]' | @TCLSH_PROG@ ; )

 uninstall-local:
-       rm -fr $(RIVETLIB_DESTDIR)
+       rm -fr ${DESTDIR}$(RIVETLIB_DESTDIR)


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org


Re: DESTDIR in Makefile.am

Posted by Massimo Manghi <ma...@unipr.it>.
In fact RIVETLIB_DESTDIR was thought to be an absolute path to allow
rivetlib to be placed outside the apache tree. I think you're right
in most cases assuming the directory within apache tree and therefore
we should handle also relative paths. If we want
to handle properly both relative and absolute paths
the script that has to be changed is 
configure.ac, where RIVET_TCL_TARGET is defined.
I don't know if autotools have a portable way to check for
absolute paths but I will look up for such a macro as soon as I'm
back home next week.

  -- Massimo


On Tue, 23 Dec 2008 15:08:49 -0500, Kiko wrote
> Can someone fix the Makefile.am in the main dir
> it doesn't have support for DESTDIR
> so using make install DESTDIR=/wherever wouldn't work with the modules
> 
> --- Makefile.am 2008-12-23 02:09:34 -0500
> +++ Makefile.am.new     2008-12-23 15:12:53 -0500
> @@ -16,11 +16,11 @@
>         $(SHELL) ./config.status --recheck
> 
>  install-data-local:
> -       $(mkinstalldirs) $(RIVETLIB_DESTDIR)
> -       cp -r rivet/* $(RIVETLIB_DESTDIR)
> -       -( cd  $(RIVETLIB_DESTDIR) ; echo 'eval pkg_mkIndex -verbose 
> [pwd] init.tcl [glob [file join packages * *.tcl] [file join *[info 
> sharedlibextension]]]' | @TCLSH_PROG@ ; ) +       $(mkinstalldirs) 
> ${DESTDIR}$(RIVETLIB_DESTDIR) +       cp -r rivet/* 
> ${DESTDIR}$(RIVETLIB_DESTDIR) +       -( cd  
> ${DESTDIR}$(RIVETLIB_DESTDIR) ; echo 'eval pkg_mkIndex -verbose 
> [pwd] init.tcl [glob [file join packages * *.tcl] [file join *[info 
> sharedlibextension]]]' | @TCLSH_PROG@ ; )
> 
>  uninstall-local:
> -       rm -fr $(RIVETLIB_DESTDIR)
> +       rm -fr ${DESTDIR}$(RIVETLIB_DESTDIR)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
> For additional commands, e-mail: rivet-dev-help@tcl.apache.org


--


---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-dev-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-dev-help@tcl.apache.org