You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/29 15:57:23 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #8310:
[FLINK-12331][network] Introduce partition/gate setup to decouple task
registration with NetworkEnvironment
azagrebin commented on a change in pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8310#discussion_r279398673
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -131,6 +140,9 @@ public ResultPartition(
ResultPartitionType partitionType,
int numberOfSubpartitions,
int numTargetKeyGroups,
+ int networkBuffersPerChannel,
Review comment:
Maybe, we could simplify it by passing a `Supplier<BufferPool> bufferPoolToSetup` from `NetworkEnvironment` to `ResultPartition`? Code to create `ResultPartition` could still stay in `NetworkEnvironment`. `registerBufferPool ` could also stay in `ResultPartition`, become private and called in `setup`: `registerBufferPool(bufferPoolToSetup.get())`. The builder in tests could have some dummy or null supplier by default to avoid changes in tests where setting of BufferPool is not relevant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services