You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2016/04/18 23:07:32 UTC
Review Request 46346: Add @Timed annotations to cron stores.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1665
https://issues.apache.org/jira/browse/AURORA-1665
Repository: aurora
Description
-------
Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
Diff: https://reviews.apache.org/r/46346/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46346: Add @Timed annotations to cron stores.
Posted by Zameer Manji <zm...@apache.org>.
> On April 18, 2016, 2:26 p.m., Stephan Erb wrote:
> > Wouldn't it make sense to have `cron` in the stats names somehow? Just from reading `/vars` it will be difficult for operators to figure out that those are covering cron jobs.
Good catch, updating the metrics.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/#review129438
-----------------------------------------------------------
On April 18, 2016, 2:07 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46346/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 2:07 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1665
> https://issues.apache.org/jira/browse/AURORA-1665
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
>
> Diff: https://reviews.apache.org/r/46346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46346: Add @Timed annotations to cron stores.
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/#review129438
-----------------------------------------------------------
Wouldn't it make sense to have `cron` in the stats names somehow? Just from reading `/vars` it will be difficult for operators to figure out that those are covering cron jobs.
- Stephan Erb
On April 18, 2016, 11:07 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46346/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 11:07 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1665
> https://issues.apache.org/jira/browse/AURORA-1665
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
>
> Diff: https://reviews.apache.org/r/46346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46346: Add @Timed annotations to cron stores.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/#review129442
-----------------------------------------------------------
Master (a619731) is red with this patch.
./build-support/jenkins/build.sh
[1m with temporary_dir() as checkpoint_root:[0m
[1m te = AuroraExecutor([0m
[1m> runner_provider=make_provider(checkpoint_root),[0m
[1m sandbox_provider=DefaultTestSandboxProvider())[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:580:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in make_provider
[1m pex_location=thermos_runner_path(),[0m
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
build = True
[1m def thermos_runner_path(build=True):[0m
[1m if not build:[0m
[1m return getattr(thermos_runner_path, 'value', None)[0m
[1m [0m
[1m if not hasattr(thermos_runner_path, 'value'):[0m
[1m pex_dir = safe_mkdtemp()[0m
[1m> assert subprocess.call(["./pants", "--pants-distdir=%s" % pex_dir, "binary",[0m
[1m "src/main/python/apache/thermos/runner:thermos_runner"]) == 0[0m
[1m[31mE assert 1 == 0[0m
[1m[31mE + where 1 = <function call at 0x7ff2c9432b18>(['./pants', '--pants-distdir=/tmp/user/10021/tmpdMEPxB', 'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])[0m
[1m[31mE + where <function call at 0x7ff2c9432b18> = subprocess.call[0m
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: AssertionError
-------------- Captured stderr call --------------
Traceback (most recent call last):
File "/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", line 7, in <module>
from pants.bin.pants_exe import main
ImportError: No module named pants.bin.pants_exe
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
[1m[31m 16 failed, 632 passed, 6 skipped, 1 warnings, 8 error in 180.56 seconds [0m
FAILURE
[32m
Waiting for background workers to finish.[0m
21:56:58 04:09 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 18, 2016, 9:50 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46346/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 9:50 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1665
> https://issues.apache.org/jira/browse/AURORA-1665
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
>
> Diff: https://reviews.apache.org/r/46346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 46346: Add @Timed annotations to cron stores.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/
-----------------------------------------------------------
(Updated April 18, 2016, 2:50 p.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Update metrics names to include cron.
Bugs: AURORA-1665
https://issues.apache.org/jira/browse/AURORA-1665
Repository: aurora
Description
-------
Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
Diff: https://reviews.apache.org/r/46346/diff/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 46346: Add @Timed annotations to cron stores.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46346/#review129437
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On April 18, 2016, 9:07 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46346/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 9:07 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1665
> https://issues.apache.org/jira/browse/AURORA-1665
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both cron stores don't have @Timed annoations. This adds them so operators can look at the throughput of storage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java 365494c0bfca7b633c57bf97762473df458ef1aa
>
> Diff: https://reviews.apache.org/r/46346/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>