You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/11/09 18:18:17 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/414
ZEPPELIN-387 Allow enable/disable of specific paragraphs
- When "run all" is called the disabled paragraphs are not executed.
- There is no "run" button for a disabled paragraph.
Disabled paragraph menu item
<img width="287" alt="screen shot 2015-11-09 at 10 30 42 pm" src="https://cloud.githubusercontent.com/assets/2031306/11040681/87673328-8733-11e5-8507-f366a222ecf1.png">
---
Enabled paragraph menu item
<img width="266" alt="screen shot 2015-11-09 at 10 30 26 pm" src="https://cloud.githubusercontent.com/assets/2031306/11040702/a39ae012-8733-11e5-8c7d-33fedc6ea6a7.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin ZEPPELIN-387
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/414.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #414
----
commit 226493a3a9c3c3ac8aad3b1d79138c3b13c05941
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-11-09T17:09:22Z
ZEPPELIN-387 Allow enable/disable of specific paragraphs
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158595978
Tested, works as expected on FF, chrome, safari, IE10 and Edge (12)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-157418759
@corneadoug fixed the z.run() case in bdf703d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158579034
@corneadoug @Leemoonsoo build issues are fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158633626
Tested, working nicely. Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/414
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-158911266
merging if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155385289
Hi @corneadoug,
That sounds like a right spot for the enable/disable menu item. Updated in 87aa4e8. Please take a look at the new screenshots. Thanks!
enabled
<img width="248" alt="screen shot 2015-11-10 at 4 09 26 pm" src="https://cloud.githubusercontent.com/assets/2031306/11060353/a1d2983c-87c5-11e5-85e3-ba2aad2844a1.png">
disabled
<img width="273" alt="screen shot 2015-11-10 at 4 09 15 pm" src="https://cloud.githubusercontent.com/assets/2031306/11060354/a1d4acd0-87c5-11e5-9752-14326a870f6f.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156947126
I tried it, and there might be another case we should handle:
z.run(4) (for example) will run your paragraph.
I think it could be better if this kind of could not run it either
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156930130
@Leemoonsoo @corneadoug @jongyoul updates from 3a7175a
<img width="260" alt="screen shot 2015-11-16 at 11 49 30 am" src="https://cloud.githubusercontent.com/assets/2031306/11175456/6b5e88dc-8c58-11e5-99ff-adfcee4e15b9.png">
<img width="248" alt="screen shot 2015-11-16 at 11 49 21 am" src="https://cloud.githubusercontent.com/assets/2031306/11175455/6b5e6a3c-8c58-11e5-8ef7-caf6d0dcb0d8.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155631510
+1 for Enable/Disable run than Enable/Disable paragraph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155625281
After thinking about it more, _Enable paragraph_ and _Disable paragraph_ can be a bit confusing since the paragraph is still shown.
_Enable run_ and _Disable run_ would be more meaningfull. And for the Icon, we should have the same as the run button, not an icon that change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-156318918
+1 for `Enable/Disable run`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-155297426
Hi,
Maybe you could keep the same style as the other (without checkbox) and with an icon (like the run button).
Also that menu position could be lower in the list (I think between ``Show line numbers`` and ``Link this paragraph`` is a good spot)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-387 Allow enable/disable...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/414#issuecomment-157604401
@r-kamath seems there is some test failing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---