You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org> on 2018/05/14 22:22:55 UTC
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Vuk Ercegovac has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10397
Change subject: IMPALA-7017: deflake/fix test_catalog_restart test
......................................................................
IMPALA-7017: deflake/fix test_catalog_restart test
The custom_cluster/test_metadata_replicas.py:test_catalog_restart
test has been recently flaky/broken for two reasons:
1) Variable support for Hive and non-hdfs filesystems. Other tests that
depend on Hive have disabled tests for non-hdfs filesystems. Since the
functionality tested is not intended for all filesystems, this change
disables this test for all filesystems other than hdfs.
2) Several builds have been flaky when looking up catalogd's version.
This change adds a retry for obtaining the version.
Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
---
M tests/common/impala_service.py
M tests/custom_cluster/test_metadata_replicas.py
2 files changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/10397/1
--
To view, visit http://gerrit.cloudera.org:8080/10397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Gerrit-Change-Number: 10397
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10397 )
Change subject: IMPALA-7017: deflake/fix test_catalog_restart test
......................................................................
IMPALA-7017: deflake/fix test_catalog_restart test
The custom_cluster/test_metadata_replicas.py:test_catalog_restart
test has been recently flaky/broken for two reasons:
1) Variable support for Hive and non-hdfs filesystems. Other tests that
depend on Hive have disabled tests for non-hdfs filesystems. Since the
functionality tested is not intended for all filesystems, this change
disables this test for all filesystems other than hdfs.
2) Several builds have been flaky when looking up catalogd's version.
This change adds a retry for obtaining the version.
Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Reviewed-on: http://gerrit.cloudera.org:8080/10397
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_service.py
M tests/custom_cluster/test_metadata_replicas.py
2 files changed, 22 insertions(+), 3 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Gerrit-Change-Number: 10397
Gerrit-PatchSet: 2
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10397 )
Change subject: IMPALA-7017: deflake/fix test_catalog_restart test
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2490/
--
To view, visit http://gerrit.cloudera.org:8080/10397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Gerrit-Change-Number: 10397
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 May 2018 05:36:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10397 )
Change subject: IMPALA-7017: deflake/fix test_catalog_restart test
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Gerrit-Change-Number: 10397
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 May 2018 09:01:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7017: deflake/fix test catalog restart test
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10397 )
Change subject: IMPALA-7017: deflake/fix test_catalog_restart test
......................................................................
Patch Set 1: Code-Review+2
This looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/10397
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6edb01f0bd7f5408cfef28fd05fdc95fb78469
Gerrit-Change-Number: 10397
Gerrit-PatchSet: 1
Gerrit-Owner: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 May 2018 23:56:19 +0000
Gerrit-HasComments: No