[GitHub] [airflow] eladkal commented on a diff in pull request #26146: Add one_done trigger rule

[GitBox <gi...@apache.org>]

eladkal commented on code in PR #26146:
URL: https://github.com/apache/airflow/pull/26146#discussion_r965949271


##########
tests/ti_deps/deps/test_trigger_rule_dep.py:
##########
@@ -151,7 +151,7 @@ def test_one_failure_tr_success(self, get_task_instance):
         dep_statuses = tuple(
             TriggerRuleDep()._evaluate_trigger_rule(
                 ti=ti,
-                successes=0,
+                successes=1,

Review Comment:
   Why do we need to change test of another trigger rule?



##########
tests/ti_deps/deps/test_trigger_rule_dep.py:
##########
@@ -163,6 +163,26 @@ def test_one_failure_tr_success(self, get_task_instance):
         )
         assert len(dep_statuses) == 0
 
+    def test_one_done_tr_success(self, get_task_instance):

Review Comment:
   Can we have more tests to cover the full functionality of the trigger rule?
   We have here 1 test for success..
   We need also 1 for skip, 1 for upstream failed I think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org