You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "jrudolph (via GitHub)" <gi...@apache.org> on 2023/02/14 12:54:58 UTC
[GitHub] [incubator-pekko-http] jrudolph opened a new pull request, #50: fix config in HttpServerLatencyMultiNodeSpec
jrudolph opened a new pull request, #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50
Seems to be an oversight from renaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#issuecomment-1429706312
@jrudolph I already made a PR https://github.com/apache/incubator-pekko-http/pull/48 that renames the classes/functions that have akka in their name, should I merge that first and then you can rebase this PR against it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#discussion_r1105787383
##########
http-tests/src/multi-jvm/scala/org/apache/pekko/http/PekkoHttpServerLatencyMultiNodeSpec.scala:
##########
@@ -36,8 +36,9 @@ object AkkaHttpServerLatencyMultiNodeSpec extends MultiNodeConfig {
stream.materializer.debug.fuzzing-mode = off
testconductor.barrier-timeout = 30m
-
- test.AkkaHttpServerLatencySpec {
+ }
+ pekko {
Review Comment:
This is the fix, the rest is just extra renamings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph merged pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph merged PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#issuecomment-1429725883
Ugh `scalafmt` does not work for multi-jvm tests...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on a diff in pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on code in PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#discussion_r1105793774
##########
http-tests/src/multi-jvm/scala/org/apache/pekko/http/PekkoHttpServerLatencyMultiNodeSpec.scala:
##########
@@ -145,13 +146,13 @@ class AkkaHttpServerLatencyMultiNodeSpec extends MultiNodeSpec(AkkaHttpServerLat
})
}
- val enableSpec = system.settings.config.getBoolean("org.apache.pekko.test.AkkaHttpServerLatencySpec.enable")
+ val enableSpec = system.settings.config.getBoolean("pekko.test.PekkoHttpServerLatencySpec.enable")
Review Comment:
The problem was that these referenced the config above which had the keys still under `akka` (and also would never move to `org.apache.pekko`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] jrudolph commented on pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#issuecomment-1429730308
> I think this is because we are using using [`main`/.scalafmt.conf#L77](https://github.com/apache/incubator-pekko-http/blob/main/.scalafmt.conf?rgh-link-date=2023-02-14T13%3A12%3A56Z#L77) which assumes a default sbt/scala project layout but it can be completely customized, see [scalameta.org/scalafmt/docs/configuration.html#projectlayout](https://scalameta.org/scalafmt/docs/configuration.html#projectlayout)
No, it's because the sbt plugin works differently than the command line tool. Fix in #51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-http] mdedetrich commented on pull request #50: fix config in HttpServerLatencyMultiNodeSpec
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #50:
URL: https://github.com/apache/incubator-pekko-http/pull/50#issuecomment-1429728898
> Ugh scalafmt does not work for multi-jvm tests...
I think this is because we are using using https://github.com/apache/incubator-pekko-http/blob/main/.scalafmt.conf#L77 which assumes a default sbt/scala project layout but it can be completely customized, see https://scalameta.org/scalafmt/docs/configuration.html#projectlayout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org