[GitHub] [iceberg] Zhangg7723 commented on a diff in pull request #5100: Data: delete compaction optimization by bloom filter

[GitBox <gi...@apache.org>]

Zhangg7723 commented on code in PR #5100:
URL: https://github.com/apache/iceberg/pull/5100#discussion_r906952929


##########
data/src/main/java/org/apache/iceberg/data/DeleteFilter.java:
##########
@@ -148,6 +168,12 @@ private List<Predicate<T>> applyEqDeletes() {
 
       Schema deleteSchema = TypeUtil.select(requiredSchema, ids);
 
+      if (filePath.endsWith(".parquet") && parquetReader != null) {

Review Comment:
   yes, you are right, but dataFile is not passed into DeleteFilter as parameter, it was changed to filePath in #4381 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org