You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/30 05:04:42 UTC
[GitHub] [shardingsphere] gavenpeng opened a new pull request, #21846: Consul repository support use localhost consul agent if not config server list
gavenpeng opened a new pull request, #21846:
URL: https://github.com/apache/shardingsphere/pull/21846
Consul repository support use localhost consul agent if not config server list
for example:
-- one:
ClusterPersistRepositoryConfiguration clusterPersistRepositoryConfiguration = new ClusterPersistRepositoryConfiguration("Consul", "", "", new Properties())
consul type repository support serverLists param is empty, if is empty, use the default localhost.
Others Changes proposed in this pull request:
- remove the code of no relation with lock from ConsulDistributedLockHolder
- improve the unit test performance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21846: Consul repository support use localhost consul agent if not config server list
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21846:
URL: https://github.com/apache/shardingsphere/pull/21846#issuecomment-1296121520
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21846?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21846](https://codecov.io/gh/apache/shardingsphere/pull/21846?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5490ae9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a1e490dc9ed7c68013d8f02e0a79ead44dc4b740?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1e490d) will **increase** coverage by `0.04%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #21846 +/- ##
============================================
+ Coverage 60.93% 60.97% +0.04%
- Complexity 2445 2451 +6
============================================
Files 4107 4107
Lines 57268 57274 +6
Branches 9678 9680 +2
============================================
+ Hits 34894 34924 +30
+ Misses 19471 19442 -29
- Partials 2903 2908 +5
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21846?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...uster/consul/lock/ConsulDistributedLockHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/21846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2NvbnN1bC9sb2NrL0NvbnN1bERpc3RyaWJ1dGVkTG9ja0hvbGRlci5qYXZh) | `8.33% <ø> (-5.00%)` | :arrow_down: |
| [...de/repository/cluster/consul/ConsulRepository.java](https://codecov.io/gh/apache/shardingsphere/pull/21846/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS90eXBlL2NsdXN0ZXIvcmVwb3NpdG9yeS9wcm92aWRlci9jb25zdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvcmVwb3NpdG9yeS9jbHVzdGVyL2NvbnN1bC9Db25zdWxSZXBvc2l0b3J5LmphdmE=) | `43.18% <33.33%> (+34.32%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #21846: Consul repository support use localhost consul agent if not config server list
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #21846:
URL: https://github.com/apache/shardingsphere/pull/21846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org