You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2021/08/17 00:55:32 UTC

[Impala-ASF-CR] IMPALA-10783: Fixed flakiness in run and verify query cancellation test

Hello Csaba Ringhofer, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/17768

to look at the new patch set (#2).

Change subject: IMPALA-10783: Fixed flakiness in run_and_verify_query_cancellation_test
......................................................................

IMPALA-10783: Fixed flakiness in run_and_verify_query_cancellation_test

The issue was that after the impala-shell is started in a seperate
process and an error is encountered then the process lingers on
and a long running query can hold on to resources and potentially
affect other tests running on the impala cluster.
This patch just makes sure that the impala-shell process is killed
regardless of any errors encountered.

Change-Id: I9f6d22d639921051cde5675fae1845bedb61c8cc
---
M tests/shell/test_shell_commandline.py
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/17768/2
-- 
To view, visit http://gerrit.cloudera.org:8080/17768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9f6d22d639921051cde5675fae1845bedb61c8cc
Gerrit-Change-Number: 17768
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>