[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #1356: fix: create-cluser issue

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1356:
URL: https://github.com/apache/incubator-kvrocks/pull/1356#discussion_r1148531408


##########
utils/create-cluster/create-cluster:
##########
@@ -65,7 +65,7 @@ then
         sed -i.bak "s|port.*|port ${PORT}|g" ${conf_file} && rm ${conf_file}.bak
         sed -i.bak "s|dir.*|dir "node_${PORT}"|g" ${conf_file} && rm ${conf_file}.bak
         $BIN_PATH/kvrocks -c ${conf_file}
-        sleep 1
+        sleep 2 # wait enough time

Review Comment:
   I think we can detect if the port is serving like the below:
   
   ```shell
   until nc -z 127.0.0.1 3004; do
     echo "instance is not ready"
     sleep 1
   done
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org