[jira] [Commented] (YARN-9047) FairScheduler: default resource calculator is not resource type aware

["Wilfred Spiegelenburg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16696698#comment-16696698 ] 

Wilfred Spiegelenburg commented on YARN-9047:
---------------------------------------------

Even before the build shows up: the code change for the scheduler looks good but I have a comment on the test change:
* there is a rogue debugger import line
* For creating the resource type config you use the {{CustomResourceTypesConfigurationProvider}}. There is a simple utility in the {{TestResourceUtils}} to do that for you: {{addNewTypesToResources}} or even directly via exposed methods in ResourceUtils (bit more work).
* Can the hamcrest dependencies be avoided by using junit assert? 

last nit: You have used the {{CustomResourceTypesConfigurationProvider}} class to create the resource type config. It is part of the webapp which seems a bit of a strange place to have a util class. Probably good to file a follow up to  jira to move it out of the webapp path and add it to some test utililities path.

> FairScheduler: default resource calculator is not resource type aware
> ---------------------------------------------------------------------
>
>                 Key: YARN-9047
>                 URL: https://issues.apache.org/jira/browse/YARN-9047
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-9047.001.patch
>
>
> The FairScheduler#getResourceCalculator always returns the default resource calculator. The default calculator is not resource type aware and should only be used if there are no resource types configured.
> We need to make sure that in we the direct hard code reference to {{RESOURCE_CALCULATOR}} is either safe to use in all cases or is not used  in the scheduler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org