You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by samueltardieu <gi...@git.apache.org> on 2015/02/16 17:45:57 UTC
[GitHub] couchdb pull request: Consume JSON body even when its content is i...
GitHub user samueltardieu opened a pull request:
https://github.com/apache/couchdb/pull/303
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type be set to "application/json". However, when some content is provided (such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content is read from the incoming HTTP request.
Fixes COUCHDB-2583
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samueltardieu/couchdb consume-json-body
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit 120ce333e8103d2cd8cf79fefaf1ced6d01db893
Author: Samuel Tardieu <sa...@rfc1149.net>
Date: 2015-02-16T13:17:10Z
Consume JSON body even when its content is ignored
"_ensure_full_commit" and "_compact" require that the content-type
be set to "application/json". However, when some content is provided
(such as "{}" in order to send a valid JSON external representation
for the empty object), CouchDB needs to ensure that this content
is read from the incoming HTTP request.
Fixes COUCHDB-2583
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Consume JSON body even when its content is i...
Posted by samueltardieu <gi...@git.apache.org>.
Github user samueltardieu closed the pull request at:
https://github.com/apache/couchdb/pull/303
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Consume JSON body even when its content is i...
Posted by samueltardieu <gi...@git.apache.org>.
Github user samueltardieu commented on the pull request:
https://github.com/apache/couchdb/pull/303#issuecomment-74639746
(note that the Travis CI build passed, it looks like there has been a change in configuration as both builds above point to the same URL)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Consume JSON body even when its content is i...
Posted by samueltardieu <gi...@git.apache.org>.
Github user samueltardieu commented on the pull request:
https://github.com/apache/couchdb/pull/303#issuecomment-75015063
Ok, will resubmit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb pull request: Consume JSON body even when its content is i...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb/pull/303#issuecomment-75014514
@samueltardieu Could you please rebase your PR against 1.x.x branch - if there will happens 1.x release it will be 1.7, not 1.6.2.
Also to let your patch be included in 2.0 submit it to https://github.com/apache/couchdb-couch/ . Worth to check if something is needed to add for cluster httpd interface (https://github.com/apache/couchdb-chttpd/), but it seems not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---