You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2014/03/06 10:51:13 UTC
svn commit: r1574822 -
/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
Author: mbertozzi
Date: Thu Mar 6 09:51:13 2014
New Revision: 1574822
URL: http://svn.apache.org/r1574822
Log:
HBASE-10678 Make verifyrep tool implement toolrunner (Bharath Vissapragada)
Modified:
hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
Modified: hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java?rev=1574822&r1=1574821&r2=1574822&view=diff
==============================================================================
--- hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java (original)
+++ hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java Thu Mar 6 09:51:13 2014
@@ -23,6 +23,7 @@ import java.io.IOException;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.conf.Configured;
import org.apache.hadoop.hbase.*;
import org.apache.hadoop.hbase.client.HConnectable;
import org.apache.hadoop.hbase.client.HConnection;
@@ -45,6 +46,8 @@ import org.apache.hadoop.hbase.zookeeper
import org.apache.hadoop.hbase.zookeeper.ZKUtil;
import org.apache.hadoop.mapreduce.Job;
import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
+import org.apache.hadoop.util.Tool;
+import org.apache.hadoop.util.ToolRunner;
/**
* This map-only job compares the data from a local table with a remote one.
@@ -56,7 +59,7 @@ import org.apache.hadoop.mapreduce.lib.o
* Two counters are provided, Verifier.Counters.GOODROWS and BADROWS. The reason
* for a why a row is different is shown in the map's log.
*/
-public class VerifyReplication {
+public class VerifyReplication extends Configured implements Tool {
private static final Log LOG =
LogFactory.getLog(VerifyReplication.class);
@@ -293,6 +296,16 @@ public class VerifyReplication {
" --starttime=1265875194289 --endtime=1265878794289 5 TestTable ");
}
+ @Override
+ public int run(String[] args) throws Exception {
+ Configuration conf = this.getConf();
+ Job job = createSubmittableJob(conf, args);
+ if (job != null) {
+ return job.waitForCompletion(true) ? 0 : 1;
+ }
+ return 1;
+ }
+
/**
* Main entry point.
*
@@ -300,10 +313,7 @@ public class VerifyReplication {
* @throws Exception When running the job fails.
*/
public static void main(String[] args) throws Exception {
- Configuration conf = HBaseConfiguration.create();
- Job job = createSubmittableJob(conf, args);
- if (job != null) {
- System.exit(job.waitForCompletion(true) ? 0 : 1);
- }
+ int res = ToolRunner.run(HBaseConfiguration.create(), new VerifyReplication(), args);
+ System.exit(res);
}
}