You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by iamhumanbeing <gi...@git.apache.org> on 2017/08/24 10:23:57 UTC
[GitHub] spark pull request #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & S...
GitHub user iamhumanbeing opened a pull request:
https://github.com/apache/spark/pull/19037
SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3) to Seq(2, 2, 2, 3) in Ex…
## What changes were proposed in this pull request?
ExchangeCoordinatorSuite.scala
Line 424: assert(exchanges.map(_.outputPartitioning.numPartitions).toSet === Set(2, 3)) is not so precisely.
change to
assert(exchanges.map(_.outputPartitioning.numPartitions).toSeq === Seq(2, 2, 2, 3))
Line 476: assert(exchanges.map(_.outputPartitioning.numPartitions).toSet === Set(5, 3)) is not so precisely.
change to
assert(exchanges.map(_.outputPartitioning.numPartitions).toSeq === Seq(5, 3, 5))
## How was this patch tested?
run ExchangeCoordinatorSuite unit tests.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iamhumanbeing/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19037
----
commit 77fee981d2cc0ee505a1bf853d1fe3fb53346340
Author: Peng Xiao <xi...@zte.com.cn>
Date: 2017-08-24T18:15:00Z
change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3) to Seq(2, 2, 2, 3) in ExchangeCoordinatorSuite.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & S...
Posted by iamhumanbeing <gi...@git.apache.org>.
Github user iamhumanbeing closed the pull request at:
https://github.com/apache/spark/pull/19037
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19037
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...
Posted by iamhumanbeing <gi...@git.apache.org>.
Github user iamhumanbeing commented on the issue:
https://github.com/apache/spark/pull/19037
@srowen How about "assert(exchanges.map(_.outputPartitioning.numPartitions).sorted === List(2, 2, 2, 3))"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19037
Are you sure that the test can rely on the ordering? it seems to explicitly not do so
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/19037
Same, why do you think the test can or should be more specific? There is no motivation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19037: SPARK-21825: change Set(5, 3) to Seq(5, 3, 5) & Set(2, 3...
Posted by iamhumanbeing <gi...@git.apache.org>.
Github user iamhumanbeing commented on the issue:
https://github.com/apache/spark/pull/19037
ok. I will close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org