You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Christian Geisert <ch...@isu-gmbh.de> on 2002/07/01 16:54:12 UTC
Re: System.exit stuff
Oleg Tkachenko schrieb:
> Hello!
>
> btw, I've just noticed AWT previewer is broken in cvs maintenance
> branch. Actually the previewer itself is ok, but it is closed when page
I noticed this while testing your patch ;-)
> is ready to show due to System.exit(0) at the end of Fop.java main
> method. I believe Fop.java main method shouldn't close jvm in the case
> of AWT mode, because AWT previewer has its own exit facility.
Simplest solution seems to be to remove System.exit(0) from Fop.java
(I'll committ this together with Oleg's patch)
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by Christian Geisert <ch...@isu-gmbh.de>.
J.Pietschmann schrieb:
> Keiron Liddle wrote:
>
>> That explains it. The execution is separated between the
>> CommandLineStarter and the AWTStarter and it needs to call exit when
>> being run with the CommandLineStarter but not the AWTStarter.
>
>
> I've added other exits() in the catch clauses. Could
> this cause trouble too? For some reason, FOP AWT
I don't think so.
> currently doesn't run at all, and I havn't got yet
> time to investigate.
The removal of System.exit(0) in Fop.java fixes this.
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by "J.Pietschmann" <j3...@yahoo.de>.
Keiron Liddle wrote:
> That explains it. The execution is separated between the
> CommandLineStarter and the AWTStarter and it needs to call exit when
> being run with the CommandLineStarter but not the AWTStarter.
I've added other exits() in the catch clauses. Could
this cause trouble too? For some reason, FOP AWT
currently doesn't run at all, and I havn't got yet
time to investigate.
Sometimes it seems to me file-to-file renderers and
the AWT renderer should be placed in different
applications.
J.Pietschmann
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by Keiron Liddle <ke...@aftexsw.com>.
On Mon, 2002-07-01 at 21:25, J.Pietschmann wrote:
> Keiron Liddle wrote:
> > You do know that every second person will complain that FOP "hangs" if
> > you remove this. :/
>
> The exit() Oleg complained about was inserted by me.
> No problem with removing it, the real exit(0) is in
> the CommandLineStarter (odd place...).
>
> J.Pietschmann
That explains it. The execution is separated between the
CommandLineStarter and the AWTStarter and it needs to call exit when
being run with the CommandLineStarter but not the AWTStarter.
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by "J.Pietschmann" <j3...@yahoo.de>.
Keiron Liddle wrote:
> You do know that every second person will complain that FOP "hangs" if
> you remove this. :/
The exit() Oleg complained about was inserted by me.
No problem with removing it, the real exit(0) is in
the CommandLineStarter (odd place...).
J.Pietschmann
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by Christian Geisert <ch...@isu-gmbh.de>.
Keiron Liddle schrieb:
> On Mon, 2002-07-01 at 16:54, Christian Geisert wrote:
>
>>Simplest solution seems to be to remove System.exit(0) from Fop.java
>>(I'll committ this together with Oleg's patch)
>
>
> You do know that every second person will complain that FOP "hangs" if
> you remove this. :/
Mmmh .. there has been no System.exit in Fop.java until 19 of June.
Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org
Re: System.exit stuff
Posted by Keiron Liddle <ke...@aftexsw.com>.
On Mon, 2002-07-01 at 16:54, Christian Geisert wrote:
> Simplest solution seems to be to remove System.exit(0) from Fop.java
> (I'll committ this together with Oleg's patch)
You do know that every second person will complain that FOP "hangs" if
you remove this. :/
> Christian
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-dev-unsubscribe@xml.apache.org
For additional commands, email: fop-dev-help@xml.apache.org