[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field
URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r326855992
 
 

 ##########
 File path: benchmarks/src/main/java/org/apache/druid/benchmark/FloatCompressionBenchmark.java
 ##########
 @@ -55,12 +55,15 @@
 @OutputTimeUnit(TimeUnit.MILLISECONDS)
 public class FloatCompressionBenchmark
 {
+  @SuppressWarnings("SSBasedInspection")
 
 Review comment:
   Please try to minimize these suppressions. In most *Benchmark and *Test classes static fields could be converted into instance fields.
   
   In classes where this cannot be done, it makes sense to add `@SuppressWarnings("SSBasedInspection")` once on the class declaration instead of separately on every field.
   
   In any case, *each* `@SuppressWarnings("SSBasedInspection")` should have a comment after it specifying the concrete type of Structural Search inspection being suppressed. In this PR, many of them should all look like
   ```java
   @SuppressWarnings("SSBasedInspection") // static field(s) cannot be final because set in an initializer block
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org