[GitHub] prabhashthere commented on issue #252: Github is failing to clean up webhooks during DELETE lifecycle

[GitBox <gi...@apache.org>]

prabhashthere commented on issue #252: Github is failing to clean up webhooks during DELETE lifecycle
URL: https://github.com/apache/incubator-openwhisk-catalog/issues/252#issuecomment-426534800
 
 
   This happens if we edited the created webhook manually. sometimes the callBackUrl will be slightly changed if you just pressed the edit button of the webhook (whether you did any changes or not).
   
   The callBackUrl which github package sends to create the webhook includes the TCP port name 443.  But if we try to edit the webhook, github will remove the port name (which is not mandatorily needed to find the trigger location) from the callBackUrl. When the package tries to delete the webhook, they look for the previous callbackUrl and it is not available anymore causing a failure in deleting the webhook.
   If we can update the git package to generate the callBackUrl without the port name, then we can mitigate this problem.
   
   **Example callBackUrls**
   before edit: `https://auth@apihost:443/api/v1/namespaces/_/triggers/myGitTrigger`
   after edit: `https://auth@apihost/api/v1/namespaces/_/triggers/myGitTrigger`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services