You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/21 10:45:11 UTC

[GitHub] [shardingsphere] kimmking opened a new pull request #5734: optimize ds config

kimmking opened a new pull request #5734:
URL: https://github.com/apache/shardingsphere/pull/5734


   
   Changes proposed in this pull request:
   - optimize ds config
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #5734: optimize ds config

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #5734:
URL: https://github.com/apache/shardingsphere/pull/5734#issuecomment-632112533


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=h1) Report
   > Merging [#5734](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/8e778cf602e03a7f8f5c87a58a178ddbfc7a6c53&el=desc) will **decrease** coverage by `0.12%`.
   > The diff coverage is `18.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/5734/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5734      +/-   ##
   ============================================
   - Coverage     53.34%   53.21%   -0.13%     
   - Complexity      428      429       +1     
   ============================================
     Files          1160     1161       +1     
     Lines         20485    20536      +51     
     Branches       3685     3708      +23     
   ============================================
   + Hits          10928    10929       +1     
   - Misses         8893     8938      +45     
   - Partials        664      669       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ocol/postgresql/constant/PostgreSQLColumnType.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9jb25zdGFudC9Qb3N0Z3JlU1FMQ29sdW1uVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...et/command/query/text/PostgreSQLDataRowPacket.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGItcHJvdG9jb2wtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGIvcHJvdG9jb2wvcG9zdGdyZXNxbC9wYWNrZXQvY29tbWFuZC9xdWVyeS90ZXh0L1Bvc3RncmVTUUxEYXRhUm93UGFja2V0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/proxy/config/yaml/YamlDataSourceParameter.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcveWFtbC9ZYW1sRGF0YVNvdXJjZVBhcmFtZXRlci5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (+1.00)` | |
   | [...ostgresql/auth/PostgreSQLAuthenticationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQvc2hhcmRpbmdzcGhlcmUtcHJveHktZnJvbnRlbmQtcG9zdGdyZXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvZnJvbnRlbmQvcG9zdGdyZXNxbC9hdXRoL1Bvc3RncmVTUUxBdXRoZW50aWNhdGlvbkVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...oxy/config/yaml/YamlDataSourceParameterMerger.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcveWFtbC9ZYW1sRGF0YVNvdXJjZVBhcmFtZXRlck1lcmdlci5qYXZh) | `17.02% <17.39%> (ø)` | `0.00 <0.00> (?)` | |
   | [...here/proxy/config/ShardingConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcvU2hhcmRpbmdDb25maWd1cmF0aW9uTG9hZGVyLmphdmE=) | `50.00% <100.00%> (-35.72%)` | `1.00 <0.00> (ø)` | |
   | [.../proxy/config/yaml/YamlProxyRuleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9jb25maWcveWFtbC9ZYW1sUHJveHlSdWxlQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...re/proxy/backend/schema/ShardingSphereSchemas.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9zY2hlbWEvU2hhcmRpbmdTcGhlcmVTY2hlbWFzLmphdmE=) | `30.76% <0.00%> (-3.85%)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/shardingsphere/proxy/Bootstrap.java](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9Cb290c3RyYXAuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/5734/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=footer). Last update [6f43f4b...d0f514e](https://codecov.io/gh/apache/shardingsphere/pull/5734?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #5734: optimize ds config

Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5734:
URL: https://github.com/apache/shardingsphere/pull/5734


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org