[GitHub] [httpcomponents-core] carterkozak commented on a change in pull request #207: HTTPCORE-640: http response out of order checks work on java 13+

[GitBox <gi...@apache.org>]

carterkozak commented on a change in pull request #207:
URL: https://github.com/apache/httpcomponents-core/pull/207#discussion_r465043949



##########
File path: httpcore5/src/main/java/org/apache/hc/core5/http/impl/io/DefaultBHttpClientConnection.java
##########
@@ -157,8 +156,8 @@ public void sendRequestEntity(final ClassicHttpRequest request) throws HttpExcep
         try (final OutputStream outStream = createContentOutputStream(
                 len, this.outbuffer, new OutputStream() {
 
-                    final boolean ssl = socketHolder.getSocket() instanceof SSLSocket;
                     final InputStream socketInputStream = socketHolder.getInputStream();
+                    final boolean earlyResponseCheckRequiresRead = !(socketInputStream instanceof FileInputStream);

Review comment:
       Hmm, this will fall back to the slow implementation when LoggingSocketHolder is used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org