[jira] [Commented] (LUCENE-9796) fix SortedDocValues to no longer extend BinaryDocValues

["Bruno Roustant (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-9796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292769#comment-17292769 ] 

Bruno Roustant commented on LUCENE-9796:
----------------------------------------

+1

> fix SortedDocValues to no longer extend BinaryDocValues
> -------------------------------------------------------
>
>                 Key: LUCENE-9796
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9796
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-9796.patch, LUCENE-9796_prototype.patch
>
>
> SortedDocValues give ordinals and a way to derefence ordinal as a byte[]
> But currently they *extend* BinaryDocValues, which allows directly calling {{binaryValue()}}.
> This allows them to act as a "slow" BinaryDocValues, but it is a performance trap, especially now that terms bytes may be block-compressed (LUCENE-9663).
> I think this should be detangled to prevent performance traps like LUCENE-9795: SortedDocValues shouldn't have the trappy inherited {{binaryValue()}} method that implicitly derefs the ord for the doc, then the term bytes for the ord.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org