You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Bibin A Chundatt (JIRA)" <ji...@apache.org> on 2017/06/05 10:29:04 UTC

[jira] [Comment Edited] (YARN-6428) Queue AM limit is not honored in CS always

    [ https://issues.apache.org/jira/browse/YARN-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036779#comment-16036779 ] 

Bibin A Chundatt edited comment on YARN-6428 at 6/5/17 10:28 AM:
-----------------------------------------------------------------

During offline discussion with [~naganarasimha_gr@apache.org] for
{code}
  @Override
  public Resource multiplyAndNormalizeUp(Resource r, double by,
      Resource stepFactor) {
    return Resources.createResource(
        roundUp(
            (int)Math.ceil(r.getMemorySize() * by), stepFactor.getMemorySize()),
        roundUp(
            (int)Math.ceil(r.getVirtualCores() * by),
            stepFactor.getVirtualCores())
        );
  }
{code}

In the above base code instead off {{(int)Math.ceil(r.getMemorySize() * by)}} it should be {{(long)Math.ceil(r.getMemorySize() * by)}} . For *DefaultResourceCalculator* {{long}} is used but *DominantResourceCalculator* {{int}} is used.Seems to be a miss during type datatype change


was (Author: bibinchundatt):
Adding point we had in offline discussion with [~naganarasimha_gr@apache.org]
{code}
  @Override
  public Resource multiplyAndNormalizeUp(Resource r, double by,
      Resource stepFactor) {
    return Resources.createResource(
        roundUp(
            (int)Math.ceil(r.getMemorySize() * by), stepFactor.getMemorySize()),
        roundUp(
            (int)Math.ceil(r.getVirtualCores() * by),
            stepFactor.getVirtualCores())
        );
  }
{code}

In the above base code instead off {{(int)Math.ceil(r.getMemorySize() * by)}} it should be {{(long)Math.ceil(r.getMemorySize() * by)}} . For DefaultResource Calculator {{long}} is used but *DefaultResourceCalculator* {{int}} is used.

> Queue AM limit is not honored  in CS always
> -------------------------------------------
>
>                 Key: YARN-6428
>                 URL: https://issues.apache.org/jira/browse/YARN-6428
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6428.0001.patch
>
>
> Steps to reproduce
> ------------------------
> Setup cluster with 40 GB and 40 vcores with 4 Node managers with 10 GB each.
> Configure 100% to default queue as capacity and max am limit as 10 %
> Minimum scheduler memory and vcore as 512,1
> *Expected* 
> AM limit 4096 and 4 vores
> *Actual*
> AM limit 4096+512 and 4+1 vcore



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org