[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42416: [SPARK-44741][CORE] Support regex-based MetricFilter in `StatsdSink`

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42416:
URL: https://github.com/apache/spark/pull/42416#discussion_r1289383886


##########
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala:
##########
@@ -59,6 +61,7 @@ class StatsdSinkSuite extends SparkFunSuite {
     val props = new Properties
     defaultProps.foreach(e => props.put(e._1, e._2))
     props.put(STATSD_KEY_PORT, socket.getLocalPort.toString)
+    props.put(STATSD_KEY_REGEX, "test-[0-9]+.driver.(CodeGenerator|BlockManager)")

Review Comment:
   This seems to break all the other test cases except the newly added one. Could you run this whole test suite locally and fix the bug?
   ```
   [info] *** 4 TESTS FAILED ***
   [error] Failed: Total 3673, Failed 4, Errors 0, Passed 3669, Ignored 10, Canceled 4
   [error] Failed tests:
   [error] 	org.apache.spark.metrics.sink.StatsdSinkSuite
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org