You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by Sheng Wu <wu...@gmail.com> on 2021/03/06 10:07:21 UTC
[DISCUSS or VOTE] Do we need to upgrade version number to v9?
Hi SkyWalking team
With receiving Jiapeng's optimization PR[1] about ElasticSearch storage,
technically, this is a very good enhancement to reduce the payload of the
ES server. But also, as I mentioned here[2], the index policy changed.
I want to ask the whole community, whether we should change the version to
9.0 after this PR merges.
Personally, I can't see much change in SkyWalking's design, streaming core,
and most other features. This may be a break enhancement, but it is not a
very big issue, as the agent->server protocol keeps unchanged.
My idea is to +1 for keeping in 8.5.0. All committers and PMC members,
welcome to vote in this format,
> +/- 1 (binding if PMC) to version number
Such as, mine is +1 (binding) to 8.5.0
[1] https://github.com/apache/skywalking/pull/6499
[2] https://github.com/apache/skywalking/issues/6411
Sheng Wu 吴晟
Twitter, wusheng1108
Re: [DISCUSS or VOTE] Do we need to upgrade version number to v9?
Posted by Sheng Wu <wu...@gmail.com>.
PR.merged, and we will make it running on the demo env for testing.
Sheng Wu 吴晟
Twitter, wusheng1108
Sheng Wu <wu...@gmail.com> 于2021年3月11日周四 上午9:56写道：
> Hi
>
> I want to remind you all, this PR is closing to be ready. If you have
> objections to keeping in 8.5.0, please make sure you reply here.
> https://github.com/apache/skywalking/pull/6499
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Jian Tan <ta...@apache.org> 于2021年3月8日周一 下午4:04写道：
>
>> +1 (binding) to 8.5.0
>>
>> Sheng Wu <wu...@gmail.com> 于2021年3月8日周一 上午10:19写道：
>>
>> > Hongtao
>> >
>> > Do you mean +1 binding to stay in 8.5.0?
>> >
>> > Sheng Wu 吴晟
>> > Twitter, wusheng1108
>> >
>> >
>> > Hongtao Gao <ha...@apache.org> 于2021年3月8日周一 上午10:08写道：
>> >
>> > > +1 binding
>> > >
>> > > On Sat, 6 Mar 2021 at 18:07, Sheng Wu <wu...@gmail.com>
>> wrote:
>> > >
>> > > > Hi SkyWalking team
>> > > >
>> > > > With receiving Jiapeng's optimization PR[1] about ElasticSearch
>> > storage,
>> > > > technically, this is a very good enhancement to reduce the payload
>> of
>> > the
>> > > > ES server. But also, as I mentioned here[2], the index policy
>> changed.
>> > > > I want to ask the whole community, whether we should change the
>> version
>> > > to
>> > > > 9.0 after this PR merges.
>> > > > Personally, I can't see much change in SkyWalking's design,
>> streaming
>> > > core,
>> > > > and most other features. This may be a break enhancement, but it is
>> > not a
>> > > > very big issue, as the agent->server protocol keeps unchanged.
>> > > > My idea is to +1 for keeping in 8.5.0. All committers and PMC
>> members,
>> > > > welcome to vote in this format,
>> > > >
>> > > > > +/- 1 (binding if PMC) to version number
>> > > >
>> > > > Such as, mine is +1 (binding) to 8.5.0
>> > > >
>> > > > [1] https://github.com/apache/skywalking/pull/6499
>> > > > [2] https://github.com/apache/skywalking/issues/6411
>> > > >
>> > > > Sheng Wu 吴晟
>> > > > Twitter, wusheng1108
>> > > >
>> > >
>> >
>>
>>
>> --
>> Jian Tan
>> Apache SkyWalking Committer && PMC, DaoCloud Labs
>> Twitter, @tanjian2015
>>
>
Re: [DISCUSS or VOTE] Do we need to upgrade version number to v9?
Posted by Sheng Wu <wu...@gmail.com>.
Hi
I want to remind you all, this PR is closing to be ready. If you have
objections to keeping in 8.5.0, please make sure you reply here.
https://github.com/apache/skywalking/pull/6499
Sheng Wu 吴晟
Twitter, wusheng1108
Jian Tan <ta...@apache.org> 于2021年3月8日周一 下午4:04写道：
> +1 (binding) to 8.5.0
>
> Sheng Wu <wu...@gmail.com> 于2021年3月8日周一 上午10:19写道：
>
> > Hongtao
> >
> > Do you mean +1 binding to stay in 8.5.0?
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > Hongtao Gao <ha...@apache.org> 于2021年3月8日周一 上午10:08写道：
> >
> > > +1 binding
> > >
> > > On Sat, 6 Mar 2021 at 18:07, Sheng Wu <wu...@gmail.com>
> wrote:
> > >
> > > > Hi SkyWalking team
> > > >
> > > > With receiving Jiapeng's optimization PR[1] about ElasticSearch
> > storage,
> > > > technically, this is a very good enhancement to reduce the payload of
> > the
> > > > ES server. But also, as I mentioned here[2], the index policy
> changed.
> > > > I want to ask the whole community, whether we should change the
> version
> > > to
> > > > 9.0 after this PR merges.
> > > > Personally, I can't see much change in SkyWalking's design, streaming
> > > core,
> > > > and most other features. This may be a break enhancement, but it is
> > not a
> > > > very big issue, as the agent->server protocol keeps unchanged.
> > > > My idea is to +1 for keeping in 8.5.0. All committers and PMC
> members,
> > > > welcome to vote in this format,
> > > >
> > > > > +/- 1 (binding if PMC) to version number
> > > >
> > > > Such as, mine is +1 (binding) to 8.5.0
> > > >
> > > > [1] https://github.com/apache/skywalking/pull/6499
> > > > [2] https://github.com/apache/skywalking/issues/6411
> > > >
> > > > Sheng Wu 吴晟
> > > > Twitter, wusheng1108
> > > >
> > >
> >
>
>
> --
> Jian Tan
> Apache SkyWalking Committer && PMC, DaoCloud Labs
> Twitter, @tanjian2015
>
Re: [DISCUSS or VOTE] Do we need to upgrade version number to v9?
Posted by Jian Tan <ta...@apache.org>.
+1 (binding) to 8.5.0
Sheng Wu <wu...@gmail.com> 于2021年3月8日周一 上午10:19写道：
> Hongtao
>
> Do you mean +1 binding to stay in 8.5.0?
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Hongtao Gao <ha...@apache.org> 于2021年3月8日周一 上午10:08写道：
>
> > +1 binding
> >
> > On Sat, 6 Mar 2021 at 18:07, Sheng Wu <wu...@gmail.com> wrote:
> >
> > > Hi SkyWalking team
> > >
> > > With receiving Jiapeng's optimization PR[1] about ElasticSearch
> storage,
> > > technically, this is a very good enhancement to reduce the payload of
> the
> > > ES server. But also, as I mentioned here[2], the index policy changed.
> > > I want to ask the whole community, whether we should change the version
> > to
> > > 9.0 after this PR merges.
> > > Personally, I can't see much change in SkyWalking's design, streaming
> > core,
> > > and most other features. This may be a break enhancement, but it is
> not a
> > > very big issue, as the agent->server protocol keeps unchanged.
> > > My idea is to +1 for keeping in 8.5.0. All committers and PMC members,
> > > welcome to vote in this format,
> > >
> > > > +/- 1 (binding if PMC) to version number
> > >
> > > Such as, mine is +1 (binding) to 8.5.0
> > >
> > > [1] https://github.com/apache/skywalking/pull/6499
> > > [2] https://github.com/apache/skywalking/issues/6411
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> >
>
--
Jian Tan
Apache SkyWalking Committer && PMC, DaoCloud Labs
Twitter, @tanjian2015
Re: [DISCUSS or VOTE] Do we need to upgrade version number to v9?
Posted by Sheng Wu <wu...@gmail.com>.
Hongtao
Do you mean +1 binding to stay in 8.5.0?
Sheng Wu 吴晟
Twitter, wusheng1108
Hongtao Gao <ha...@apache.org> 于2021年3月8日周一 上午10:08写道：
> +1 binding
>
> On Sat, 6 Mar 2021 at 18:07, Sheng Wu <wu...@gmail.com> wrote:
>
> > Hi SkyWalking team
> >
> > With receiving Jiapeng's optimization PR[1] about ElasticSearch storage,
> > technically, this is a very good enhancement to reduce the payload of the
> > ES server. But also, as I mentioned here[2], the index policy changed.
> > I want to ask the whole community, whether we should change the version
> to
> > 9.0 after this PR merges.
> > Personally, I can't see much change in SkyWalking's design, streaming
> core,
> > and most other features. This may be a break enhancement, but it is not a
> > very big issue, as the agent->server protocol keeps unchanged.
> > My idea is to +1 for keeping in 8.5.0. All committers and PMC members,
> > welcome to vote in this format,
> >
> > > +/- 1 (binding if PMC) to version number
> >
> > Such as, mine is +1 (binding) to 8.5.0
> >
> > [1] https://github.com/apache/skywalking/pull/6499
> > [2] https://github.com/apache/skywalking/issues/6411
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
>
Re: [DISCUSS or VOTE] Do we need to upgrade version number to v9?
Posted by Hongtao Gao <ha...@apache.org>.
+1 binding
On Sat, 6 Mar 2021 at 18:07, Sheng Wu <wu...@gmail.com> wrote:
> Hi SkyWalking team
>
> With receiving Jiapeng's optimization PR[1] about ElasticSearch storage,
> technically, this is a very good enhancement to reduce the payload of the
> ES server. But also, as I mentioned here[2], the index policy changed.
> I want to ask the whole community, whether we should change the version to
> 9.0 after this PR merges.
> Personally, I can't see much change in SkyWalking's design, streaming core,
> and most other features. This may be a break enhancement, but it is not a
> very big issue, as the agent->server protocol keeps unchanged.
> My idea is to +1 for keeping in 8.5.0. All committers and PMC members,
> welcome to vote in this format,
>
> > +/- 1 (binding if PMC) to version number
>
> Such as, mine is +1 (binding) to 8.5.0
>
> [1] https://github.com/apache/skywalking/pull/6499
> [2] https://github.com/apache/skywalking/issues/6411
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>