You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/08/08 16:13:48 UTC
[GitHub] tinkerpop pull request #689: TINKERPOP-1743: LambdaRestrictionStrategy does ...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/689
TINKERPOP-1743: LambdaRestrictionStrategy does not catch lambdas passed to sack()
https://issues.apache.org/jira/browse/TINKERPOP-1743
Fixed a lambda-leak in `SackValueStep` where `BiFunction` must be tested for true lambda status.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1743
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/689.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #689
----
commit 1e04d928a0b87f6aa82e77756f5458d62b14a6d9
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-08-08T16:12:11Z
Fixed a lambda-leak in SackValueStep where BiFunction could be a real lambda.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #689: TINKERPOP-1743: LambdaRestrictionStrategy does not cat...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/689
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #689: TINKERPOP-1743: LambdaRestrictionStrategy does not cat...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/689
I rebased this on tp32 and force pushed to get rid of that extra "fix" commit for bigdecimal. @okram you should:
```text
git fetch
git branch -D TINKERPOP-1743
git checkout TINKERPOP-1743
```
before you merge this to release branches.
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #689: TINKERPOP-1743: LambdaRestrictionStrategy does not cat...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/689
```
gremlin> g = TinkerFactory.createModern().traversal()
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g = g.withStrategies(LambdaRestrictionStrategy.instance())
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g.withSack(0).V().limit(1).sack{ v,s -> System.exit(1) }
The provided step contains a lambda bi-function: SackValueStep(lambda)
Type ':help' or ':h' for help.
Display stack trace? [yN]
gremlin>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #689: TINKERPOP-1743: LambdaRestrictionStrategy does not cat...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/689
VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #689: TINKERPOP-1743: LambdaRestrictionStrategy does ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/689
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---