You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "John Crossman (JIRA)" <ji...@apache.org> on 2011/09/02 23:23:10 UTC
[jira] [Created] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
-----------------------------------------------------------------
Key: VALIDATOR-296
URL: https://issues.apache.org/jira/browse/VALIDATOR-296
Project: Commons Validator
Issue Type: Bug
Components: Framework
Affects Versions: 1.3.1 Release
Reporter: John Crossman
This assertion fails for me:
assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501154#comment-13501154 ]
Gary Gregory commented on VALIDATOR-296:
----------------------------------------
Feel free to provide a patch ;)
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Nick Burch (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158380#comment-13158380 ]
Nick Burch commented on VALIDATOR-296:
--------------------------------------
I've just added some unit tests in r1207110, and I'm not seeing the problem you describe. The following new asserts all pass just fine:
assertTrue(
"/ and ! valid in username",
validator.isValid("joe!/blow@apache.org")
);
assertFalse(
"/ not valid in domain",
validator.isValid("joe@ap/ache.org")
);
assertFalse(
"! not valid in domain",
validator.isValid("joe@apac!he.org")
);
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Robert Oschwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501303#comment-13501303 ]
Robert Oschwald commented on VALIDATOR-296:
-------------------------------------------
Compared with 1.4.0.
There the bug is fixed. (Seems fix was introduced in rev. 586637)
For me, the ticket can be closed. Thanks.
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved VALIDATOR-296.
----------------------------
Resolution: Fixed
Fix Version/s: 1.4.0 Release
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
> Fix For: 1.4.0 Release
>
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Robert Oschwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501106#comment-13501106 ]
Robert Oschwald commented on VALIDATOR-296:
-------------------------------------------
Any news to this long running open issue? It shouldn't be that hard to fix the regex.
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501155#comment-13501155 ]
Gary Gregory commented on VALIDATOR-296:
----------------------------------------
Feel free to provide a patch ;)
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Erhan Bagdemir (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158603#comment-13158603 ]
Erhan Bagdemir commented on VALIDATOR-296:
------------------------------------------
assertFalse(
"/ not valid in domain",
validator.isValid("joe@ap/ache.org")
);
would pass, just because that you asserts "false".
assertTrue will fail :/
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (VALIDATOR-296)
EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
Posted by "Robert Oschwald (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132605#comment-13132605 ]
Robert Oschwald edited comment on VALIDATOR-296 at 10/21/11 12:05 PM:
----------------------------------------------------------------------
Corrected comment:
joe@foo/bar.com and any other pattern including !/ fail.
Reason is, that 000-177 is allowed and the domain part (group2) is only tested for occurrences, not characters.
was (Author: roos):
Are you testing 1.3.1? This version doesn't define isValidEmail()...
joe@foo/bar.com is correctly detected here in 1.3.1, but the pattern
assertFalse("joe@!foobar.com Validator failed",EmailValidator.getInstance().isValid("joe@!foobar.com"));
fails here. EmailValidator detects this as a valid address.
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (VALIDATOR-296) EmailValidator#isValid(String)
returns true for "joe@foo/bar.com"
Posted by "Robert Oschwald (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/VALIDATOR-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132605#comment-13132605 ]
Robert Oschwald commented on VALIDATOR-296:
-------------------------------------------
Are you testing 1.3.1? This version doesn't define isValidEmail()...
joe@foo/bar.com is correctly detected here in 1.3.1, but the pattern
assertFalse("joe@!foobar.com Validator failed",EmailValidator.getInstance().isValid("joe@!foobar.com"));
fails here. EmailValidator detects this as a valid address.
> EmailValidator#isValid(String) returns true for "joe@foo/bar.com"
> -----------------------------------------------------------------
>
> Key: VALIDATOR-296
> URL: https://issues.apache.org/jira/browse/VALIDATOR-296
> Project: Commons Validator
> Issue Type: Bug
> Components: Framework
> Affects Versions: 1.3.1 Release
> Reporter: John Crossman
>
> This assertion fails for me:
> assertFalse(EmailValidator.getInstance().isValidEmail("joe@foo/bar.com"));
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira