You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by pengcheng xiong <px...@hortonworks.com> on 2015/09/18 20:20:51 UTC
Review Request 38503: Support special characters in quoted table names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 7d7e7c0
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java ed022d9
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java fb954d8
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review99878
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 533)
<https://reviews.apache.org/r/38503/#comment156895>
1. Capture allowed chars as "chars that need encoding" + "others"
2. May be keep "chars that need encoding" as hash set
3. Create allowed chars pattern from #1
4. Add method here to check char that needs encoding which should be a check in to hashset at #2
5. All of these data structs could be static
- John Pullokkaran
On Sept. 18, 2015, 6:20 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:20 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 7d7e7c0
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java ed022d9
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java fb954d8
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review99879
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java (line 191)
<https://reviews.apache.org/r/38503/#comment156896>
This should be changed to metastoreutils.doesthischarneedsencoding or something. It should be metastoreutils since it already has the logic for valid table names.
- John Pullokkaran
On Sept. 18, 2015, 6:20 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:20 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 7d7e7c0
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java ed022d9
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java fb954d8
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review101046
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 1737)
<https://reviews.apache.org/r/38503/#comment158353>
Make a note that unicode is not supported in table names. And we have explicit checks for it.
- John Pullokkaran
On Sept. 22, 2015, 6:12 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:12 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review101045
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2177)
<https://reviews.apache.org/r/38503/#comment158352>
We should list what special chars are supported; may be by accessing MetaStoreUtils field.
- John Pullokkaran
On Sept. 22, 2015, 6:12 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:12 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review101162
-----------------------------------------------------------
Ship it!
Ship It!
- John Pullokkaran
On Sept. 30, 2015, 9:57 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 9:57 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review101399
-----------------------------------------------------------
Ship it!
Ship It!
- Lefty Leverenz
On Oct. 2, 2015, 12:03 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 12:03 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dffdb5c
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 0082773
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 815f499
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 57b8618
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3511e73
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8efbb05
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 582ff32
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 7:03 p.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dffdb5c
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 0082773
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 815f499
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 57b8618
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3511e73
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8efbb05
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 582ff32
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 9:57 p.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 9:38 p.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Changes
-------
address Lefty and John's comments.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by Lefty Leverenz <le...@gmail.com>.
> On Sept. 29, 2015, 11:33 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177
> > <https://reviews.apache.org/r/38503/diff/1-2/?file=1076829#file1076829line2176>
> >
> > Looks good, thanks!
> >
> > But would you please change the line breaks to conform to the 100-char limit? (It's a cosmetic issue for the template file.)
> >
> > Aaarrgh, forgot to publish this review. Oh well, better late than never.
>
> Lefty Leverenz wrote:
> Line 2176 is still too long, and there's no newline char at the end so in the template file the description in lines 2176 and 2177 will run together as a single line. Please split line 2176 before "[a-zA-z" ... oh, and shouldn't it be "[a-zA-Z" (capital Z after capital A)?
>
> pengcheng xiong wrote:
> Sure. As it is a tiny change, it will be fixed in the commit version.
Okay, thanks.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review100159
-----------------------------------------------------------
On Oct. 2, 2015, 12:03 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 12:03 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java dffdb5c
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java 0082773
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 815f499
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 57b8618
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 3511e73
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 8efbb05
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 582ff32
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
> On Sept. 30, 2015, 6:33 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177
> > <https://reviews.apache.org/r/38503/diff/1-2/?file=1076829#file1076829line2176>
> >
> > Looks good, thanks!
> >
> > But would you please change the line breaks to conform to the 100-char limit? (It's a cosmetic issue for the template file.)
> >
> > Aaarrgh, forgot to publish this review. Oh well, better late than never.
>
> Lefty Leverenz wrote:
> Line 2176 is still too long, and there's no newline char at the end so in the template file the description in lines 2176 and 2177 will run together as a single line. Please split line 2176 before "[a-zA-z" ... oh, and shouldn't it be "[a-zA-Z" (capital Z after capital A)?
Sure. As it is a tiny change, it will be fixed in the commit version.
- pengcheng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review100159
-----------------------------------------------------------
On Sept. 30, 2015, 9:57 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 9:57 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by Lefty Leverenz <le...@gmail.com>.
> On Sept. 29, 2015, 11:33 p.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2176-2177
> > <https://reviews.apache.org/r/38503/diff/1-2/?file=1076829#file1076829line2176>
> >
> > Looks good, thanks!
> >
> > But would you please change the line breaks to conform to the 100-char limit? (It's a cosmetic issue for the template file.)
> >
> > Aaarrgh, forgot to publish this review. Oh well, better late than never.
Line 2176 is still too long, and there's no newline char at the end so in the template file the description in lines 2176 and 2177 will run together as a single line. Please split line 2176 before "[a-zA-z" ... oh, and shouldn't it be "[a-zA-Z" (capital Z after capital A)?
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review100159
-----------------------------------------------------------
On Sept. 30, 2015, 2:57 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 2:57 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review100159
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2176 - 2177)
<https://reviews.apache.org/r/38503/#comment157311>
Looks good, thanks!
But would you please change the line breaks to conform to the 100-char limit? (It's a cosmetic issue for the template file.)
Aaarrgh, forgot to publish this review. Oh well, better late than never.
- Lefty Leverenz
On Sept. 29, 2015, 9:56 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 29, 2015, 9:56 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
(Updated Sept. 30, 2015, 4:56 a.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by pengcheng xiong <px...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/
-----------------------------------------------------------
(Updated Sept. 22, 2015, 6:12 a.m.)
Review request for hive, Ashutosh Chauhan and John Pullokkaran.
Repository: hive-git
Description
-------
Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
ql/src/java/org/apache/hadoop/hive/ql/Driver.java 43159c6
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/38503/diff/
Testing
-------
Thanks,
pengcheng xiong
Re: Review Request 38503: Support special characters in quoted table
names
Posted by John Pullokkaran <jp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review99881
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java (line 292)
<https://reviews.apache.org/r/38503/#comment156897>
Remove passing of conf objs.
As you suggested, parser already done the check to see if special chars is legal; here we just need to handle special chars if it appears.
- John Pullokkaran
On Sept. 18, 2015, 6:20 p.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 6:20 p.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 7d7e7c0
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java ed022d9
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java fb954d8
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>
Re: Review Request 38503: Support special characters in quoted table
names
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38503/#review99901
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2176 - 2177)
<https://reviews.apache.org/r/38503/#comment156912>
Please add the information that only "[a-zA-z_0-9]+" are supported when this is false.
A full list of supported special characters would also be helpful.
Should the explanation specify that it applies only to quoted table names?
- Lefty Leverenz
On Sept. 18, 2015, 11:20 a.m., pengcheng xiong wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38503/
> -----------------------------------------------------------
>
> (Updated Sept. 18, 2015, 11:20 a.m.)
>
>
> Review request for hive, Ashutosh Chauhan and John Pullokkaran.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Right now table names can only be "[a-zA-z_0-9]+". This patch tries to investigate how much change there should be if we would like to support special characters, e.g., "/" in table names.
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 7f29da2
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ee20430
> metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java a80f686
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java f88f4dd
> metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java bc0f6e3
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 4030075
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 210736b
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DummyTxnManager.java be5a593
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/EmbeddedLockManager.java 7d7e7c0
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveLockObject.java fadd074
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/HiveTxnManagerImpl.java ed022d9
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/zookeeper/ZooKeeperHiveLockManager.java fb954d8
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c78e8f4
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java 52ed4a3
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteQueryUsingAggregateIndexCtx.java 4966d89
> ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java 8b7a2e8
> ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHive.java 1e2feaa
> ql/src/test/queries/clientnegative/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_1.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_2.q PRE-CREATION
> ql/src/test/queries/clientpositive/special_character_in_tabnames_3.q PRE-CREATION
> ql/src/test/results/clientnegative/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_1.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_2.q.out PRE-CREATION
> ql/src/test/results/clientpositive/special_character_in_tabnames_3.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/38503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengcheng xiong
>
>