[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #3083: Upgrade to arrow 20.0.0 (but no change to object_store)

[GitBox <gi...@apache.org>]

avantgardnerio commented on code in PR #3083:
URL: https://github.com/apache/arrow-datafusion/pull/3083#discussion_r940620461


##########
datafusion/core/src/datasource/file_format/json.rs:
##########
@@ -231,17 +231,21 @@ mod tests {
         projection: Option<Vec<usize>>,
         limit: Option<usize>,
     ) -> Result<Arc<dyn ExecutionPlan>> {
+        let store_root = env!("CARGO_MANIFEST_DIR");
         let filename = "tests/jsons/2.json";
         let format = JsonFormat::default();
-        scan_format(&format, ".", filename, projection, limit).await
+        scan_format(&format, store_root, filename, projection, limit).await
     }
 
     #[tokio::test]
     async fn infer_schema_with_limit() {
         let store = Arc::new(LocalFileSystem::new()) as _;
-        let filename = "tests/jsons/schema_infer_limit.json";
         let format = JsonFormat::default().with_schema_infer_max_rec(Some(3));
 
+        let store_root = std::path::Path::new(env!("CARGO_MANIFEST_DIR"));
+        let filename = store_root.join("tests/jsons/schema_infer_limit.json");
+        let filename = filename.to_str().expect("Unable to get path!");

Review Comment:
   Ah, thank you! I missed these when reverting things. I'm pushing a new commit to this PR that I think will be releasable.
   
   Sorry I missed these, I appreciate your help :raised_hands: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org