You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "advancedxy (via GitHub)" <gi...@apache.org> on 2024/03/22 15:09:01 UTC

Re: [PR] feat: Support murmur3_hash and sha2 family hash functions [arrow-datafusion-comet]

advancedxy commented on code in PR #226:
URL: https://github.com/apache/arrow-datafusion-comet/pull/226#discussion_r1535745879


##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -1628,6 +1628,7 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde {
             "make_decimal",
             DecimalType(precision, scale),
             childExpr)
+

Review Comment:
   The extra empty line is not added before and not consistent with other code, so it's added.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org