You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hivemall.apache.org by myui <gi...@git.apache.org> on 2018/08/28 10:20:50 UTC
[GitHub] incubator-hivemall pull request #157: [HIVEMALL-212] Fix Classifier/Regresso...
GitHub user myui opened a pull request:
https://github.com/apache/incubator-hivemall/pull/157
[HIVEMALL-212] Fix Classifier/Regressor not to forward zero weighted values
## What changes were proposed in this pull request?
Feature with weight = 0.0 need not to be saved in the prediction model. It is preferable to reduce the size of prediction model. So, this PR fixes Classifier/Regressor not to forward zero weighted values
## What type of PR is it?
Improvement
## What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-212
## How was this patch tested?
unit tests and manual tests
## Checklist
(Please remove this section if not needed; check `x` for YES, blank for NO)
- [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, for your commit?
- [ ] Did you run system tests on Hive (or Spark)?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myui/incubator-hivemall HIVEMALL-212
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/157.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #157
----
commit 48aacae519837a7d69c5927cf0de470d29c6ee29
Author: Makoto Yui <my...@...>
Date: 2018-08-27T09:54:16Z
Fixed not to hold zero weight features
commit 3954a2720502f027ff7f2b5b0cd08e1e77f66017
Author: Makoto Yui <my...@...>
Date: 2018-08-27T09:54:43Z
Zero division handling
commit de16c54dcb7351ea901f81a3a4263eaef347bc60
Author: Makoto Yui <my...@...>
Date: 2018-08-28T05:50:25Z
Fixed zero weighted feature handling
commit ddd88d42536dc2f59efdbcc9dfa86aeda3223a2f
Author: Makoto Yui <my...@...>
Date: 2018-08-28T05:51:41Z
Added final
----
---
[GitHub] incubator-hivemall pull request #157: [HIVEMALL-212] Fix Classifier/Regresso...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hivemall/pull/157
---