[GitHub] [shardingsphere] dongzl commented on a change in pull request #7778: Add SQLServer parser select aggregation clause, support except & intersect.

[GitBox <gi...@apache.org>]

dongzl commented on a change in pull request #7778:
URL: https://github.com/apache/shardingsphere/pull/7778#discussion_r504377842



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-sqlserver/src/main/antlr4/imports/sqlserver/DMLStatement.g4
##########
@@ -73,11 +73,15 @@ multipleTableNames
     ;
 
 select 
-    : unionClause
+    : aggregationClause
+    ;
+
+aggregationClause
+    : selectClause ((UNION (ALL)? | EXCEPT | INTERSECT) selectClause)*
     ;
 
 unionClause
-    : selectClause (UNION (ALL | DISTINCT)? selectClause)*
+    : selectClause (UNION (ALL)? selectClause)*
     ;

Review comment:
       Hi @jingshanglu , You are right, I consider merge `unionClause` to  `aggregationClause` next PR at beginning, 
   now I will do it in advance.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org