You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Francesco Chicchiriccò <no...@github.com> on 2015/03/27 11:52:33 UTC
[jclouds-labs] [JCLOUDS-849] All tests are green (#158)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs/pull/158
-- Commit Summary --
* [JCLOUDS-849] All tests are green
-- File Changes --
M azurecompute/src/main/java/org/jclouds/azurecompute/AzureManagementApiMetadata.java (7)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (262)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/config/AzureComputeServiceContextModule.java (5)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/extensions/AzureComputeSecurityGroupExtension.java (15)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/DeploymentToNodeMetadata.java (88)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/OSImageToImage.java (9)
M azurecompute/src/main/java/org/jclouds/azurecompute/compute/strategy/GetOrCreateStorageServiceAndVirtualNetworkThenCreateNodes.java (7)
A azurecompute/src/main/java/org/jclouds/azurecompute/compute/strategy/impl/AzureAdaptingComputeServiceStrategies.java (70)
M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (134)
M azurecompute/src/main/java/org/jclouds/azurecompute/suppliers/KeyStoreSupplier.java (60)
M azurecompute/src/main/java/org/jclouds/azurecompute/util/ConflictManagementPredicate.java (6)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (2)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleHandler.java (1)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleInstanceHandler.java (15)
M azurecompute/src/test/java/org/jclouds/azurecompute/AzureComputeProviderMetadataLive.java (2)
M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapterLiveTest.java (67)
M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceContextLiveTest.java (36)
A azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceLiveTest.java (57)
M azurecompute/src/test/java/org/jclouds/azurecompute/compute/extensions/AzureComputeSecurityGroupExtensionLiveTest.java (41)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (6)
M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (2)
M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (14)
M azurecompute/src/test/java/org/jclouds/azurecompute/xml/DeploymentHandlerTest.java (7)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/158.patch
https://github.com/jclouds/jclouds-labs/pull/158.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Ignasi Barrera <no...@github.com>.
Closed #158.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#event-274545146
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Andrea Turli <no...@github.com>.
Tested on my account, here the results:
Failed tests:
AzureComputeServiceLiveTest.testOptionToNotBlock:50->BaseComputeServiceLiveTest.testOptionToNotBlock:827 » RunNodes
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:708->BaseComputeServiceLiveTest.createAndRunAServiceInGroup:725 » RunNodes
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testAScriptExecutionAfterBootWithBasicTemplate:224 » RunNodes
AzureComputeServiceLiveTest>BaseComputeServiceLiveTest.testConcurrentUseOfComputeServiceToCreateNodes:476 » Execution
Tests run: 55, Failures: 4, Errors: 0, Skipped: 13
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87232885
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Francesco Chicchiriccò <no...@github.com>.
@hsbhathiya Good news then! Thanks for feedback.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87701948
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Francesco Chicchiriccò <no...@github.com>.
@andreaturli @hsbhathiya your failures should be due to to a different choice of default location (among our subscription and yours): as you can see from last commit, I have now explicitly set the default test image location to "West Europe": could you please launch the live tests again? Don't forget to clean up completely your subscription environment before.
In case of further error(s), could you please report the full error stacktrace? Thanks.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87620116
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Bhathiya <no...@github.com>.
@ilgrosso
No test failiures now.
------------------------------------------------------------------------------
Test set: TestSuite
-------------------------------------------------------------------------------
Tests run: 55, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 5,516.931 sec - in TestSuite
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87701608
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Bhathiya <no...@github.com>.
Hi great work @ilgrosso !
I tested against my azure account. Here is the [results](https://gist.github.com/hsbhathiya/aa94e79ae6a61a618c88#file-azure849live)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87229822
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Ignasi Barrera <no...@github.com>.
Fantastic work done here. Pushed to master and 1.9.x. Many thanks!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-90243717
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Ignasi Barrera <no...@github.com>.
> + prioritizeCredentialsFromTemplate,
> + client,
> + nodeMetadataAdapter,
> + imageAdapter,
> + addDefaultCredentialsToImage);
> +
> + this.client = (AzureComputeServiceAdapter) client;
> + this.nodeMetadataAdapter = nodeMetadataAdapter;
> + }
> +
> + @Override
> + public NodeMetadata destroyNode(final String id) {
> + final Deployment node = client.internalDestroyNode(id);
> + return node == null
> + ? null
> + : nodeMetadataAdapter.apply(node);
Out of curiosity, why does this method need to be overridden?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158/files#r27641652
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Francesco Chicchiriccò <no...@github.com>.
> + prioritizeCredentialsFromTemplate,
> + client,
> + nodeMetadataAdapter,
> + imageAdapter,
> + addDefaultCredentialsToImage);
> +
> + this.client = (AzureComputeServiceAdapter) client;
> + this.nodeMetadataAdapter = nodeMetadataAdapter;
> + }
> +
> + @Override
> + public NodeMetadata destroyNode(final String id) {
> + final Deployment node = client.internalDestroyNode(id);
> + return node == null
> + ? null
> + : nodeMetadataAdapter.apply(node);
The [default implementation of destroyNode()](https://github.com/jclouds/jclouds/blob/master/compute/src/main/java/org/jclouds/compute/strategy/impl/AdaptingComputeServiceStrategies.java#L177) will simply rely on `getNode()` and, if such method returns NULL, not perform any delete.
The `getNode()` logic in Azure needs to be handled in a slightly different way (a "node" is returned only when the CloudService is available and all RoleInstance elements are in a non-transient state) so we implemented the logic for a sort of "getNode for destroy" in the `internalDestroyNode`.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158/files#r27646053
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Posted by Ignasi Barrera <no...@github.com>.
Just a minor. lgtm! Thanks @ilgrosso!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-88835608