You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2017/12/28 11:54:16 UTC

[GitHub] nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity

nvazquez commented on a change in pull request #2344: CLOUDSTACK-10163: Component tests sanity
URL: https://github.com/apache/cloudstack/pull/2344#discussion_r158933656
 
 

 ##########
 File path: test/integration/component/test_VirtualRouter_alerts.py
 ##########
 @@ -47,6 +47,7 @@ def setUpClass(cls):
             cls).getClsTestClient()
         cls.api_client = cls.testClient.getApiClient()
         cls.services = cls.testClient.getParsedTestDataConfig()
+        cls.hostConfig = cls.config.__dict__["zones"][0].__dict__["pods"][0].__dict__["clusters"][0].__dict__["hosts"][0].__dict__
 
 Review comment:
   Is `cls.config` set here or should it be `cls.services?` Can we add basic check for each dictionary key?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services