[GitHub] [guacamole-client] necouchman commented on a change in pull request #382: GUACAMOLE-736: Remove JAXB data conversion in favor of Guava

[GitBox <gi...@apache.org>]

necouchman commented on a change in pull request #382: GUACAMOLE-736: Remove JAXB data conversion in favor of Guava
URL: https://github.com/apache/guacamole-client/pull/382#discussion_r262024940
 
 

 ##########
 File path: extensions/guacamole-auth-duo/src/main/java/org/apache/guacamole/auth/duo/api/SignedDuoCookie.java
 ##########
 @@ -221,7 +221,7 @@ private static String sign(String key, String data) throws GuacamoleException {
             mac.init(new SecretKeySpec(key.getBytes("UTF-8"), SIGNATURE_ALGORITHM));
 
             // Return signature as hex
-            return DatatypeConverter.printHexBinary(mac.doFinal(data.getBytes("UTF-8"))).toLowerCase();
+            return BaseEncoding.base16().encode(mac.doFinal(data.getBytes("UTF-8"))).toLowerCase();
 
 Review comment:
   Okay, swapped this over to lower prior to encoding.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services