You are viewing a plain text version of this content. The canonical link for it is here.
Posted to portalapps-dev@portals.apache.org by "Gonzalo Aguilar (JIRA)" <ji...@apache.org> on 2010/03/19 23:30:27 UTC
[jira] Created: (APA-32) Apa-RSS Include an option to disable html
escape
Apa-RSS Include an option to disable html escape
------------------------------------------------
Key: APA-32
URL: https://issues.apache.org/jira/browse/APA-32
Project: Portals Apps
Issue Type: Improvement
Components: apa-rss
Affects Versions: apa-rss-1.1
Reporter: Gonzalo Aguilar
Assignee: David Sean Taylor
Fix For: apa-rss-1.1
This issue is created to include support for full html support inside a RSS Feed.
Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (APA-32) Apa-RSS Include an option to disable html
escape
Posted by "Gonzalo Aguilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gonzalo Aguilar updated APA-32:
-------------------------------
Attachment: RSS-escape-option-apa-rss-APA-32.patch
Small fix that provide html support inside rss feeds.
It comply with slfj support requested by Woonsan and David.
> Apa-RSS Include an option to disable html escape
> ------------------------------------------------
>
> Key: APA-32
> URL: https://issues.apache.org/jira/browse/APA-32
> Project: Portals Apps
> Issue Type: Improvement
> Components: apa-rss
> Affects Versions: apa-rss-1.1
> Reporter: Gonzalo Aguilar
> Assignee: David Sean Taylor
> Fix For: apa-rss-1.1
>
> Attachments: RSS-escape-option-apa-rss-APA-32.patch
>
>
> This issue is created to include support for full html support inside a RSS Feed.
> Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (APA-32) Apa-RSS Include an option to disable
html escape
Posted by "Gonzalo Aguilar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849668#action_12849668 ]
Gonzalo Aguilar commented on APA-32:
------------------------------------
Fine!
I'm sorry I forgot to set it to false because it's my default option.
Best regards.
> Apa-RSS Include an option to disable html escape
> ------------------------------------------------
>
> Key: APA-32
> URL: https://issues.apache.org/jira/browse/APA-32
> Project: Portals Apps
> Issue Type: Improvement
> Components: apa-rss
> Affects Versions: apa-rss-1.1
> Reporter: Gonzalo Aguilar
> Assignee: David Sean Taylor
> Fix For: apa-rss-1.1
>
> Attachments: RSS-escape-option-apa-rss-APA-32.patch
>
>
> This issue is created to include support for full html support inside a RSS Feed.
> Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (APA-32) Apa-RSS Include an option to disable
html escape
Posted by "Woonsan Ko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12849666#action_12849666 ]
Woonsan Ko commented on APA-32:
-------------------------------
Hi Gonzalo,
It seems very nice and I think it's a good option!
However, I think we need to keep the default preference value as it used to be.
I mean, you added the following, but it could make some problems to the existing rss portlets which have assumed proper escaping.
+ <preference>
+ <name>disableescape</name>
+ <value>true</value>
+ </preference>
Therefore, I think we'd better the above default preference should be 'false' as it worked before.
Is it okay to change the default value to false?
Kind regards,
Woonsan
> Apa-RSS Include an option to disable html escape
> ------------------------------------------------
>
> Key: APA-32
> URL: https://issues.apache.org/jira/browse/APA-32
> Project: Portals Apps
> Issue Type: Improvement
> Components: apa-rss
> Affects Versions: apa-rss-1.1
> Reporter: Gonzalo Aguilar
> Assignee: David Sean Taylor
> Fix For: apa-rss-1.1
>
> Attachments: RSS-escape-option-apa-rss-APA-32.patch
>
>
> This issue is created to include support for full html support inside a RSS Feed.
> Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (APA-32) Apa-RSS Include an option to disable html
escape
Posted by "Woonsan Ko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko resolved APA-32.
---------------------------
Resolution: Fixed
Applied Gonzalo's patch and fixed. Thanks a lot!
Also added a unit test for this.
By the way, I applied the disable-output-escaping option to all description field including channel, item, downlevel:channel and downlevel:item.
Anyway, now RSSPortlet can have the following preference:
<preference>
<name>disableescape</name>
<value>false</value>
</preference>
If the above preference is set to true, then the description fields are generated without markup escaping.
If the above preference is not defined or set to false, then the description fields are escaped as they used to be.
Cheers,
Woonsan
> Apa-RSS Include an option to disable html escape
> ------------------------------------------------
>
> Key: APA-32
> URL: https://issues.apache.org/jira/browse/APA-32
> Project: Portals Apps
> Issue Type: Improvement
> Components: apa-rss
> Affects Versions: apa-rss-1.1
> Reporter: Gonzalo Aguilar
> Assignee: Woonsan Ko
> Fix For: apa-rss-1.1
>
> Attachments: RSS-escape-option-apa-rss-APA-32.patch
>
>
> This issue is created to include support for full html support inside a RSS Feed.
> Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (APA-32) Apa-RSS Include an option to disable html
escape
Posted by "Woonsan Ko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APA-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Woonsan Ko reassigned APA-32:
-----------------------------
Assignee: Woonsan Ko (was: David Sean Taylor)
> Apa-RSS Include an option to disable html escape
> ------------------------------------------------
>
> Key: APA-32
> URL: https://issues.apache.org/jira/browse/APA-32
> Project: Portals Apps
> Issue Type: Improvement
> Components: apa-rss
> Affects Versions: apa-rss-1.1
> Reporter: Gonzalo Aguilar
> Assignee: Woonsan Ko
> Fix For: apa-rss-1.1
>
> Attachments: RSS-escape-option-apa-rss-APA-32.patch
>
>
> This issue is created to include support for full html support inside a RSS Feed.
> Now if a feed contains html markup it will be escaped and the html code will be shown instead of showing the correct markup.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.