You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2021/09/03 16:43:42 UTC

[superset] branch master updated: fix: impersonate user label/tooltip (#16573)

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9bb890e  fix: impersonate user label/tooltip (#16573)
9bb890e is described below

commit 9bb890ebedd4b1d0aaa8e308df9014754f6f1a51
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Fri Sep 3 09:42:11 2021 -0700

    fix: impersonate user label/tooltip (#16573)
---
 .../views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx    | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx
index 03c82f4..632dcca 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/ExtraOptions.tsx
@@ -392,11 +392,13 @@ const ExtraOptions = ({
               indeterminate={false}
               checked={!!db?.impersonate_user}
               onChange={onInputChange}
-              labelText={t('Impersonate logged in user (Presto & Hive)')}
+              labelText={t(
+                'Impersonate logged in user (Presto, Trino, Hive, and GSheets)',
+              )}
             />
             <InfoTooltip
               tooltip={t(
-                'If Presto, all the queries in SQL Lab are going to be executed as the ' +
+                'If Presto or Trino, all the queries in SQL Lab are going to be executed as the ' +
                   'currently logged on user who must have permission to run them. If Hive ' +
                   'and hive.server2.enable.doAs is enabled, will run the queries as ' +
                   'service account, but impersonate the currently logged on user via ' +
@@ -490,8 +492,8 @@ const ExtraOptions = ({
           </div>
           <div className="helper">
             {t(
-              'Specify this database’s version. This should be used with ' +
-                'Presto databases so that the syntax is correct.',
+              'Specify the database version. This should be used with ' +
+                'Presto in order to enable query cost estimation.',
             )}
           </div>
         </StyledInputContainer>